1090272 - Attempting to switch to an invalid frame causes a server side error

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

If you do try to switch to an invalid index:

framesLength = marionette.execute_script("return window.frames.length")
marionette.switch_to_frame(framesLength)

or any number higher than framesLength, then the server will try to switch into that non-existing frame and will hit an exception:

W/GeckoConsole(  206): [JavaScript Error: "TypeError: curFrame is undefined" {file: "chrome://marionette/content/marionette-listener.js" line: 1778}]

We should instead detect that we don't have this number of frames and return an appropriate error.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Also errors out for invalid frame indices like -2

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Raise NoSuchFrameException when attempting to switch to a non-existant frame by index. v1.0

Try:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=d7dd77333f24

Comment 3

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8512830 [details] [diff] [review]
Raise NoSuchFrameException when attempting to switch to a non-existant frame by index. v1.0

Review of attachment 8512830 [details] [diff] [review]:
-----------------------------------------------------------------

awesome, works well locally

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69d426d27d31

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69d426d27d31