Add mach target for cpp unittests on Android and B2G

RESOLVED WORKSFORME

Status

defect
RESOLVED WORKSFORME
5 years ago
Last year

People

(Reporter: dminor, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

5 years ago
Bug 949538 added a mach target to run cppunittests for desktop builds. Since we also support these tests on Android and B2G, we should add support to mach for this use case as well.
Depends on: 1202102
I've used the mochitest mach command for inspiration and tried to use a similar (but simpler) structure. This only adds special handling for android; I think b2g would be easy to add, but I'm less comfortable with that...will leave open for b2g follow-up.

I have tested with "mach cppunittest" and "mach cppunittest <objdir>/dist/TestFile" on both Android and Linux. Also: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1fb27ebb622
Assignee: nobody → gbrown
Attachment #8660099 - Flags: review?(dminor)
Reporter

Comment 2

4 years ago
Comment on attachment 8660099 [details] [diff] [review]
add mach cppunittest support for android

Review of attachment 8660099 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8660099 - Flags: review?(dminor) → review+
Leaving open for b2g.
Keywords: leave-open
Assignee: gbrown → nobody
Only b2g left. Closing.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → WORKSFORME
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.