If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add mach target for cpp unittests on Android and B2G

RESOLVED WORKSFORME

Status

()

Core
Build Config
RESOLVED WORKSFORME
3 years ago
6 months ago

People

(Reporter: dminor, Unassigned)

Tracking

({leave-open})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Bug 949538 added a mach target to run cppunittests for desktop builds. Since we also support these tests on Android and B2G, we should add support to mach for this use case as well.

Updated

2 years ago
Depends on: 1202102
Created attachment 8660099 [details] [diff] [review]
add mach cppunittest support for android

I've used the mochitest mach command for inspiration and tried to use a similar (but simpler) structure. This only adds special handling for android; I think b2g would be easy to add, but I'm less comfortable with that...will leave open for b2g follow-up.

I have tested with "mach cppunittest" and "mach cppunittest <objdir>/dist/TestFile" on both Android and Linux. Also: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1fb27ebb622
Assignee: nobody → gbrown
Attachment #8660099 - Flags: review?(dminor)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8660099 [details] [diff] [review]
add mach cppunittest support for android

Review of attachment 8660099 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8660099 - Flags: review?(dminor) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b89b4f875deb
Leaving open for b2g.
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/b89b4f875deb

Updated

2 years ago
Assignee: gbrown → nobody

Comment 6

6 months ago
Only b2g left. Closing.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.