Closed Bug 1090374 Opened 6 years ago Closed 3 months ago

Convert MessageChannel::mLink to a UniquePtr

Categories

(Core :: IPC, defect, P3)

Product:
Core
Component:
IPC
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 1090374 - Convert MessageChannel::mLink to a UniquePtr.
47 bytes, text/x-phabricator-request
Details | Review 
This will make it harder to accidentally leak.
Priority: -- → P3

I was going to file this bug, but lo and behold, I already filed it 6 years ago.

Summary: Convert MessageChannel::mLink to an nsAutoPtr → Convert MessageChannel::mLink to a UniquePtr
Severity: normal → N/A
Assignee: nobody → continuation

I thought there was a race in the existing code, but on further thought, it is just my patch that introduces a race. See bug 1644922.

See Also: → 1644922
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35c1f0461407
Convert MessageChannel::mLink to a UniquePtr. r=froydnj

https://hg.mozilla.org/mozilla-central/rev/35c1f0461407

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.