1090421 - e10s suitenames need to be adjusted for holly

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[William Lachance (:wlach)]

Talos "other" seems to be failing on holly because of an undefined suitename:

https://treeherder.mozilla.org/ui/#/jobs?repo=holly&revision=252f6ee39d3e

Seeing weird errors like this:

    Badly formed talos_json for suite other-e10s_l64; KeyError trying to access talos_config['suites'][other-e10s_l64]['tests']: 'other-e10s_l64'
    No tests specified; please specify --tests
    Running post_fatal callback...
    Exiting -1

I think fixing this is likely just a matter of adjusting the suite names in talos.json and/or adjusting the mozharness arguments of what should be run.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

ok, we are missing the talos.json definitions:
https://hg.mozilla.org/projects/holly/file/tip/testing/talos/talos.json

buildbotconfigs have proper settings, but we have defined in talos.json "other-e10s" and we need to define "other-e10s_nol64" and "other-e10s_l64".  That should solve the bulk of these problems.

Here is the list of tests jobs we have defined in buildbotconfigs:
('chromez-e10s', 'dromaeojs-e10s', 'g1-e10s', 'other-e10s_l64', 'other-e10s_nol64', 'tp5o-e10s', 'svgr-e10s', 'xperf-e10s')

The talos.json on inbound doesn't have e10s changes?  should we add those in, or just fix this on holly?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'm afraid I don't understand this stuff. It would be great to get as much as possible checked into inbound though. We want the diff between inbound and holly to be as small as possible.

Comment 3

[William Lachance (:wlach)]

(In reply to Bill McCloskey (:billm) from comment #2)
> I'm afraid I don't understand this stuff. It would be great to get as much
> as possible checked into inbound though. We want the diff between inbound
> and holly to be as small as possible.

Yeah, jmaher and I basically agreed to check-in a fixed version of the holly talos.json to m-c. The e10s suites don't do any harm there (they just aren't run).

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: update talos.json on inbound with e10s definitions (1.0)

Comment 5

[William Lachance (:wlach)]

Comment on attachment 8513448 [details] [diff] [review]
update talos.json on inbound with e10s definitions (1.0)

Review of attachment 8513448 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/24241717af63

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24241717af63