1090451 - [Lockscreen] No vibration when entering passcode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Seth Miko [:SMiko]]

Description: The phone does not vibrate when entering the passcode on the lockscreen.

Repro Steps:
1: Update a Flame to 20141028040202
2: Open Settings > Sound > toggle on Vibrate
3: Open Settings > Screen lock > toggle on Passcode lock
4: Create a passcode and reboot the phone
5: Enter passcode

Actual: Vibration does not occur

Expected: Device vibrates when keys are pressed.

Device: Flame 2.2
BuildID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Repro frequency: 5/5

Comment 1

[Seth Miko [:SMiko]]

This issue does NOT repro on Flame 2.1 (319mb/full flash)

Actual result: Phone vibrates with key presses.

Device: Flame 2.1
BuildID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
___________________________________________________________________________________________________________________________________

This issue DOES repro on Flame 2.2 (319/full flash/20141027040237)

Actual result: Phone does NOT vibrate with key presses.

Device: Flame 2.2
BuildID: 20141027040237
Gaia: e91d99e4d96954f06383c00bb9d79598a697e310
Gecko: 8230834302c9
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 36.0a1 (2.2)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 2

[Oliver Nelson [:oliverthor]]

Interesting bug, could be design related in stripping the vibration from this screen.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Take. Or, at least put it in the queue.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

One typo.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Waiting the retriggered jobs done (TBPL).

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Only one intermittent error occurs:

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=2e13679eddf9

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/3e4184bbfa95b79ab35166f6f14a1325e4e70cb1

Comment 8

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2&master by the STR in Comment 0.

Actual results: When you want to set up the passcode in Settings or input the passcode for unlocking screen, device vibrates while the keys are clicked.
See attachment: verified_Flame_v2.2.3gp
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150708162504
Gaia Revision          d6d6a35b9407ffaf3131bc244cabc8ee2b09c4df
Gaia Date              2015-07-08 19:35:16
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/629912eb8659
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150708.195227
Firmware Date          Wed Jul  8 19:52:38 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150708160205
Gaia Revision          fc6643dd3da2ccdf2ab284479643836bb3698644
Gaia Date              2015-07-08 11:09:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/f34a7120f46b
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150708.193056
Firmware Date          Wed Jul  8 19:31:08 EDT 2015
Bootloader             L1TC000118D0

Comment 9

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.2.3gp