1090460 - [Contacts] Company text can be searched but only selected if text is found within Contact's name.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20141027_1217.txt

Description:
In Contacts if the User searches for the company name of a contact it will appear under the search results. The text will be selected in the company name but only if it is found within the Contact's name. For example, the contact's name is Mr Pany. If Pany is searched for Pany will be selected on the last name as well as the "pany" part of the Company called Company. But if "mpany" is searched for the contact will be found, but none of the text will be selected.


Repro Steps:
1) Update a Flame to 20141028001203
2) Create a Contact with the last name "Pany" and the Company Name "Company".
3) Search "Pany" and observe what text is selected.
4) Search "Company" and observe the text that is not selected.


Actual:
Last name text is selected when searched for. Company text appears when searched for but is only highlighted if it matches the Contact's name.

Expected:
It is expected that the company text will be highlighted when searched for regardless if it matches the Contact's name or note. 

Environmental Variables:
Device: Flame 2.1
Build ID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Version: 34.0 (2.1)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Repro frequency:100%
See attached:Logcat, Screenshots (x2)

Comment 1

[John Thomas [:Johnt]]

Attachment: CompanyTextSelected.png

Comment 2

[John Thomas [:Johnt]]

Attachment: CompanyTextnotSelected.png

Comment 3

[John Thomas [:Johnt]]

This issue does not occur on the Flame 2.2 Kk (319mb) and the Flame 2.0 Kk (319mb)

Result: In 2.2 the Company text will not be highlighted when searched for. In 2.0 the company text will appear highlighted when searched for regardless if it is found in the Contacts name or not. 

Flame 2.2

Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141028000202
Gaia: 5e532a84e762b1bb6231756182cf1465671a061e
Gecko: 124f0bed1700
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 4

[Pedro Cambra]

I've tried in nightly 2.2 and I can't reproduce the problem

Comment 5

[Phani]

Couldn't replicate on 2.2 this either.

But found new issue : https://bugzilla.mozilla.org/show_bug.cgi?id=1092589

Comment 6

[Antonio Matarrese]

Attachment: Github pull request

Hi Francisco, can you have a look at this bug fix? Now when you search a contact and it's matching with a company name this will be highlighted according to the search filter.

Comment 7

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Not nominating this issue to block. Correct searches show up, just a minor issue with highlighting search terms

Comment 8

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8515593 [details] [review]
Github pull request

Jose could you review?

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8515593 [details] [review]
Github pull request

new unit tests have to be added. In addition it would be nice to have some comments on the code indicating the algorithm followed to highlight terms.

Comment 10

[Antonio Matarrese]

Hi Jose, the code that match the terms is not inside the method that I changed. That method is called only for highlighting the nodes that have already been passed as node to be highlighted. I would like to suggest to write this comments in other part and leave this method outside the matching logic comment. About the test, there is any test that I can be inspired having a look? I should write a test that check if the company is highlighted as well? Cheers!

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Good feedback, Jose, do you think that we can do a follow up with unit tests?

Since this was a patch done during the bug squash party we didn't have much time to explain how to create unit test.

Comment 12

[Jose Manuel Cantera]

Antonio,

We are fixing all highlighting issues in bug 1088706. That is going to be accompanied by a new test suite independent of the list_test. Once that lands we can resume the work on this bug if that is still happening. 

On the other hand, we need to revise with the UX team the specs of search results as we are only showing the name of the contact but not other possible matches that are happening. 

That's bug 806496

thanks for your efforts!

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

Closing as wontfix since it's not happening in 2.2