Closed Bug 1090485 Opened 10 years ago Closed 10 years ago

mochitest --log-tbpl option writes 0 length file

Categories

(Testing :: Mochitest, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: gbrown, Assigned: chmanchester)

Details

Attachments

(1 file)

When I run mochitests locally with --log-tbpl, a mochitest-plain.log file is created, but it is always 0 length.

"make mochitest-plain" calls runtests with --log-tbpl, which looks like it should be valid, from https://developer.mozilla.org/en/docs/Mochitest.

$ make mochitest-plain --dry-run
rm -f ./mochitest-plain.log && /home/gbrown/objdirs/firefox/_virtualenv/bin/python _tests/testing/mochitest/runtests.py --autorun --close-when-done --console-level=INFO --log-tbpl=./mochitest-plain.log --failure-file=/home/gbrown/objdirs/firefox/_tests/testing/mochitest/makefailures.json --testing-modules-dir=/home/gbrown/objdirs/firefox/_tests/modules --extra-profile-file=dist/plugins --symbols-path=dist/crashreporter-symbols --test-path='content/media/mediasource' 
errors=`grep 'TEST-UNEXPECTED-' mochitest-plain.log` ; if test "$errors" ; then echo 'mochitest-plain failed:'; echo "$errors"; echo 'To rerun your failures please run "make mochitest-plain-rerun-failures"'; exit 1; fi
$ make mochitest-plain
...
$ ls -l *.log
-rw-r--r-- 1 gbrown gbrown     0 Oct 28 14:15 mochitest-plain.log

--log-raw and --log-mach create useful files, but not --log-tbpl.
I haven't successfully run the harness through make, but the issue reproduces well with this as a fix through mach.

How does this look?
Attachment #8512989 - Flags: feedback?(gbrown)
Assignee: nobody → cmanchester
Status: NEW → ASSIGNED
Comment on attachment 8512989 [details] [diff] [review]
Fix mozlog's commandline to accept file arguments for a formatter that is also the stdout default

Review of attachment 8512989 [details] [diff] [review]:
-----------------------------------------------------------------

This works fine for me. Thank you!
Attachment #8512989 - Flags: feedback?(gbrown) → feedback+
Attachment #8512989 - Flags: review?(james)
Attachment #8512989 - Flags: review?(james) → review+
https://hg.mozilla.org/mozilla-central/rev/bdf27424d1b9
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: