Status
People
(Reporter: Ehsan, Assigned: Ehsan)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment)
|
720 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This helps eliminate the need for setting C/CXXFLAGS in the mozconfig.
Attachment #8512979 -
Flags: review?(mh+mozilla)
|
||
Comment 1•5 years ago
|
||
Comment on attachment 8512979 [details] [diff] [review] Patch (v1) Review of attachment 8512979 [details] [diff] [review]: ----------------------------------------------------------------- ::: build/autoconf/toolchain.m4 @@ +76,5 @@ > + # We force clang-cl to emulate Visual C++ 2013 in configure.in, but that > + # is based on the CLANG_CL variable defined here, so make sure that we're > + # getting the right version here manually. > + CC_VERSION=1800 > + CXX_VERSION=1800 Shouldn't -fmsc-version and -fallback be added here as well? Which would make them used in js/src, which they currently aren't...
Attachment #8512979 -
Flags: review?(mh+mozilla) → review+
|
Assignee | |
Comment 2•5 years ago
|
||
Good idea, will do.
|
||
Comment 3•5 years ago
|
||
This was causing bizarre Android build failures that were fixed by clobbering. https://hg.mozilla.org/integration/mozilla-inbound/rev/33b93eb7e383
|
||
Comment 4•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52ed8be78a65 https://hg.mozilla.org/mozilla-central/rev/33b93eb7e383
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
| Comment hidden (Legacy TBPL/Treeherder Robot) |
|
||
Updated•a year ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•