Closed
Bug 1090512
Opened 11 years ago
Closed 11 years ago
Emulate the clang-cl compiler version in toolchain.m4
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla36
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
720 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This helps eliminate the need for setting C/CXXFLAGS in the mozconfig.
Attachment #8512979 -
Flags: review?(mh+mozilla)
Comment 1•11 years ago
|
||
Comment on attachment 8512979 [details] [diff] [review]
Patch (v1)
Review of attachment 8512979 [details] [diff] [review]:
-----------------------------------------------------------------
::: build/autoconf/toolchain.m4
@@ +76,5 @@
> + # We force clang-cl to emulate Visual C++ 2013 in configure.in, but that
> + # is based on the CLANG_CL variable defined here, so make sure that we're
> + # getting the right version here manually.
> + CC_VERSION=1800
> + CXX_VERSION=1800
Shouldn't -fmsc-version and -fallback be added here as well? Which would make them used in js/src, which they currently aren't...
Attachment #8512979 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 2•11 years ago
|
||
Good idea, will do.
Comment 3•11 years ago
|
||
This was causing bizarre Android build failures that were fixed by clobbering.
https://hg.mozilla.org/integration/mozilla-inbound/rev/33b93eb7e383
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/52ed8be78a65
https://hg.mozilla.org/mozilla-central/rev/33b93eb7e383
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•