Closed Bug 1090575 Opened 7 years ago Closed 7 years ago

Make it easy to generate eggs

Categories

(MozReview Graveyard :: General, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

There has been some confusion over how to properly generate .egg files. As it turns out, this confusion is warranted: getting a proper build environment for ReviewBoard eggs is a bit complicated, as it needs some Node.js dependencies. Happy days.

We should add a Docker environment to vct to make it super easy to produce eggs for rbbz and rbmozui.
Attachment #8513210 - Flags: review?(mconley)
/r/334 - testing: add Docker build environment for eggs (bug 1090575)

Pull down this commit:

hg pull review -r 31aea4f2a0e8c335c98657e65b24df8f5eea3206
Assignee: nobody → gps
Status: NEW → ASSIGNED
https://reviewboard-dev.allizom.org/r/333/#review220

I think this looks fine - though my knowledge and experience with Docker is not what I'd call "comprehensive" in the slightest.

::: docs/hacking-mozreview.rst
(Diff revision 1)
> +Want to release an update to MozReview? This section is fow you.

fow -> for

::: docs/hacking-mozreview.rst
(Diff revision 1)
> +If you wish to use the Docker container, extrace the image id from the

extrace -> extract?

I know about Docker in theory, but I've never actually used it. How does one get the ID from the command output? Which command?

::: testing/vcttesting/docker.py
(Diff revision 1)
> +        if add_vct:

It wasn't immediately obvious what this was doing (it seems to be adding every file under the version-control-tools hg repo to a tar) - some documentation to explain what this is doing and why would be good.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.