1090578 - Improve error handling when creating new protocols via Open/Bridge

Status: NEW

(Core :: IPC, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Right now we have a lot of code that looks like this:

    ProcessHandle handle;
    if (!base::OpenProcessHandle(aOtherProcess, &handle)) {
        // XXX need to kill |aOtherProcess|, it's boned
        return nullptr;
    }

    DebugOnly<bool> ok = parent->Open(aTransport, handle, XRE_GetIOMessageLoop(),
                                      mozilla::ipc::ParentSide);
    MOZ_ASSERT(ok);

(The same "it's boned" comment already appears in three places in Gecko and bug 641685 will add a fourth.)

We should really do a better job here. I'm not sure what scenarios these calls could fail in. We should either crash or handle the error gracefully.

Comment 1

[Raye Helton]

Attachment: same problem

Thanks from radismingprop1973.