Closed
Bug 1090591
Opened 10 years ago
Closed 10 years ago
test_dmd.js is broken on jemalloc3 builds
Categories
(Core :: DMD, defect)
Core
DMD
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: ggp, Assigned: ggp)
References
Details
Attachments
(1 file)
6.31 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
During the test, SmokeDMD.cpp does a 144-byte allocation, which is a size class in mozjemalloc, but gets rounded up to 160 bytes in jemalloc3, thus changing the output of DMD.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ggoncalves
Assignee | ||
Comment 1•10 years ago
|
||
Bumping the allocation size to 160 and updating the expected output files fixes this. I'll do a Try run with both jemalloc3 and mozjemalloc when Try is open again, but it works locally.
Attachment #8513067 -
Flags: review?(n.nethercote)
Comment 2•10 years ago
|
||
Comment on attachment 8513067 [details] [diff] [review] Fix test_dmd.js on jemalloc3 builds. Review of attachment 8513067 [details] [diff] [review]: ----------------------------------------------------------------- Great!
Attachment #8513067 -
Flags: review?(n.nethercote) → review+
Assignee | ||
Comment 3•10 years ago
|
||
The test now passes on both mozjemalloc (https://tbpl.mozilla.org/?tree=Try&rev=57bc1e3f0eea) and jemalloc3 (https://tbpl.mozilla.org/?tree=Try&rev=7920942cbfb0) builds.
Keywords: checkin-needed
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d7fb88f8d58
Flags: in-testsuite+
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6d7fb88f8d58
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•