1090610 - Add flag to packager that fails build if minification fails

Status: NEW

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Description

[Nick Alexander :nalexander [he/him]]

Over in Bug 1039902 and friends, I've got all of the Fennec JS minifying to an identical AST.  I'd like to preserve that property for as long as possible.  To that end, I'd like to add a flag to the packager that makes packaging fail if minification is enabled and fails.

My plan is to enable the flag for debug builds only: that way we have the red canary without killing all Fennec builds when we regress minification and/or verification.

Comment 1

[Mike Hommey [:glandium]]

(In reply to Nick Alexander :nalexander from comment #0)
> My plan is to enable the flag for debug builds only: that way we have the
> red canary without killing all Fennec builds when we regress minification
> and/or verification.

I'm not convinced there's much added value to do that on debug only.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Mike Hommey [:glandium] from comment #1)
> (In reply to Nick Alexander :nalexander from comment #0)
> > My plan is to enable the flag for debug builds only: that way we have the
> > red canary without killing all Fennec builds when we regress minification
> > and/or verification.
> 
> I'm not convinced there's much added value to do that on debug only.

This has nothing to do with debug, per se -- I want a signal but I don't want to kill all Fennec builds when this regresses.  It seems dumb to hold development back while we do the routine steps of "rev the SM version", check if that fixed things, dig into jsmin, check if that fixed things, etc.

So would you not do this at all, or do it everywhere and accept the fallout when it regresses?

Comment 3

[Mike Hommey [:glandium]]

Unless you tell sheriffs not to close the tree and/or backout changes when a build goes red, there's not much difference between only android debug builds turning red, and all the android builds turning red.

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Mike Hommey [:glandium] from comment #3)
> Unless you tell sheriffs not to close the tree and/or backout changes when a
> build goes red, there's not much difference between only android debug
> builds turning red, and all the android builds turning red.

OK, this is sensible.  I think I still want to turn builds red, so I'll add this flag.  We'll see if we can actually do this in practice.

Comment 5

[Mike Hommey [:glandium]]

My point is that I don't think you need a flag. Just make it the default and only behavior when there is validation.