[commbadge] Comments for Reviewers are showing up as Reviewer Comments

VERIFIED FIXED in 2014-11-11

Status

Marketplace
Developer Pages
P2
normal
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: ngoke, Assigned: ngoke)

Tracking

2014-11-11
x86
Mac OS X
Points:
---

Details

(Assignee)

Description

4 years ago
An oversight that makes Comments for Reviewers read as Reviewer Comment. A migration will need to be run to fix the Comments for Reviewers for all of the apps.

STR:

1. Submit an app.
2. Leave a Comments for Reviewers in the process.
3. Go to the Commbadge thread for that app.

Expected:

Note reads "Developer Comment"

Actual:

Note reads "Reviewer Comment"
(Assignee)

Updated

4 years ago
Assignee: nobody → kngo
Priority: -- → P2
(Assignee)

Comment 1

4 years ago
To make things worse, a Reviewer Comment on the review history page was accidentally made equivalent to a Reviewer Comment where a reviewer comments on a Commbadge thread. The former comment would be private from the developer, while the latter is public.
(Assignee)

Comment 2

4 years ago
Updating the STR:

1. Update a packaged app with a new version.
2. Leave something in the "Notes for Reviewers" section.
3. Go to the Commbadge thread for that app.

Expected:

Note reads "Developer Note for Reviewer" or something similar.

Actual:

Note reads "Reviewer Comment"
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 2014-11-11
(Assignee)

Comment 3

4 years ago
This is currently on -dev, not yet on stage.
what's the commit/pr?
(Assignee)

Comment 5

4 years ago
https://github.com/mozilla/zamboni/commit/e343d19066e04a8b04de77f506ebb805dd3259ef

It was an oversight since "approvalnotes" sounded a lot like something a reviewer would do.

Comment 6

4 years ago
Verified as fixed in https://marketplace.allizom.org/comm/ on FF36 (Win 7).
Postfix screencast http://screencast.com/t/zaMV4WGp
Closing bug.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.