1090761 - [System] load related script by Bluetooth API version

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[[e-mail]]

According to Ian's suggestion in bug 1089511 comment 4,

aim to construct and load new script for Bluetooth v2 only. It will need a version detection before load Bluetooth script.

EX:
Gecko::Bluetooth v1 ==> load bluetooth.js, bluetooth_transfer.js
Gecko::Bluetooth v2 ==> load bluetooth_v2.js, bluetooth_transfer_v2.js

So that we won't need to spend cost for v1. And it won't have any regression in v1.

Comment 1

[[e-mail]]

before make nfc_handover reuse system bluetooth adapter, we have to handle bootstrap order first...

Comment 2

[[e-mail]]

Attachment: pull request redirect to github

The plan is not change BT APIv1 too much and focus on APIv2 related work, so I just move module init() part from related module, and make sure the init works without error in APIv1/APIv2 device.

This is the pre-work for making nfc_handover reuse system bluetooth adapter in bug 1090799, because of the Bluetooth module dependency.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8515718 [details] [review]
pull request redirect to github

This is somewhat good, but please consider to migrate to system2
https://bugzilla.mozilla.org/show_bug.cgi?id=1092893

The most simple way to implement that is:
Write a BluetoothCore module has start/stop method and could be instantiated.
Add one line in core.js:
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/core.js#L17
'mozBluetooth': 'BluetoothCore'

Comment 4

[[e-mail], [e-mail]]

Comment on attachment 8515718 [details] [review]
pull request redirect to github

Looks good for me. As comment 3 mentioned, that is good to have 'BluetoothCore' module for sync with system2 architecture.

Comment 5

[[e-mail]]

thanks for advice. Looks like we could do it in 2.2 and make mozBluetooth in good abstraction. At this moment, let's move fast to help gecko team to test their functionality.

Comment 6

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/bc168c17474dabbcceaa349e9bc7c95654435aec

thanks!