1090762 - Add telemetry for FTP usage

Status: RESOLVED DUPLICATE of bug 1579507

(Core Graveyard :: Networking: FTP, defect, P3)

Description

[Jason Duell]

We want to get a sense of how often FTP is still being used.  I'm thinking two metrics are good enough here:

  1) Did we use FTP one or more times in the current browser session?
  2) Did we use FTP directory listings specifically? (vs just downloading a file from a link)

If daily usage is possible, that's nicer, but even per session would be a start.

Comment 1

[Daniel Stenberg [:bagder]]

Attachment: 0001-bug-1090762-Add-telemetry-for-FTP-usage-r-jduell.patch

First shot. This adds two counters, FTP_CONNECT for "connect" (including the use of a cached version) and FTP_LIST for counting actual directory listing commands used.

As a complete Telemetry newbie, I of course welcome all and any feedback.

Comment 2

[Jason Duell]

Comment on attachment 8515911 [details] [diff] [review]
0001-bug-1090762-Add-telemetry-for-FTP-usage-r-jduell.patch

Review of attachment 8515911 [details] [diff] [review]:
-----------------------------------------------------------------

Patrick, do you have an opinion here?  I was thinking we'd try to break down FTP usage not just by absolute #s but by the % of browser sessions (or % of days when a user uses FTP).

Comment 3

[Patrick McManus [:mcmanus]]

we can add telemetry, sure.

but the question I always ask is at what # or percentage is it ok to require an add-on?

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8515911 [details] [diff] [review]
0001-bug-1090762-Add-telemetry-for-FTP-usage-r-jduell.patch

Review of attachment 8515911 [details] [diff] [review]:
-----------------------------------------------------------------

this patch doesn't give us any comparables (pct of sessions for example..) its just a raw hit count - which I don't see how it helps us.

don't get me wrong, there is a lot of code in the ftp directory that is lightly used and highly risky.. it would be good to get rid of. I worry about the competitive aspect.

Could we work with an add-on author to distribute a js based ftp implementation already written?

Comment 5

[Patrick McManus [:mcmanus]]

it would be good to get this in

Comment 6

[Daniel Stenberg [:bagder]]

ack, I'll move it up on my TODO list...

Comment 7

[Valentin Gosu [:valentin] (he/him)]

I think kind: "flag" is the type of probe we need here.

Comment 8

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 9

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 10

[Mathew Hodson]

Can't this be duped to bug 1579507, which is now done?