1090810 - [Stingray] add SettingsCache to smart system

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Smart system queries lots settings. And each of them may cost ~500ms. If the amount of queries exceed 8, we may use SettingsCache to do it. Experiments on mozSettings are needed.

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: use settingscache to improve device boot time

Hi Rex,

I had changed all reading from mozSetting to read from SettingsCache. Please review this patch. For the benchmark number, please find the doc here:
https://docs.google.com/a/mozilla.com/spreadsheets/d/19BPa6GCxPPoLZxy_r1tJSPG4JZVUCbpSKwSXYjJ5Jbg/edit?usp=sharing

you may need to login as mozilla account to open it.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8514040 [details] [review]
use settingscache to improve device boot time

The code looks mostly good to me with some comments. Please see Github before landing.

Have we already opened a bug for putting local storage together with SettingsCache? If yes, please set dependency from to this bug.

Thanks for your work!

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

We don't have that bug. And it is async storage instead of local storage. I am not sure it is a correct way to improve the boot up time. We need to discuss more about this before filing issue and create the PR.

Anyway, thanks for your review. I will revise the PR with all of your concerns before landing it.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

rebased and merged to master:
https://github.com/mozilla-b2g/gaia/commit/b54f50d195232f6022bf140686b9daacda40d291

Comment 6

[:gerard-majax]

When you say 500ms, can you detail more ? It seems way much more that what we see on phones.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

Alexandre,

I use new Date().getTime() at the timing we query the mozSettings and dump the elapsed time at callback. I did not keep the testing patch.

But the experimental result is at comment 1. The same result was observed by partner. You may re-test it with the latest master.

Comment 8

[Julien Wajsberg [:julienw]]

Alexandre, I think 500ms is for the whole settings get process:

console.time('check');
mozSettings.createLock().get().onsuccess = () => console.timeEnd('check');

Comment 9

[:gerard-majax]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] from comment #7)
> Alexandre,
> 
> I use new Date().getTime() at the timing we query the mozSettings and dump
> the elapsed time at callback. I did not keep the testing patch.
> 
> But the experimental result is at comment 1. The same result was observed by
> partner. You may re-test it with the latest master.

John, thanks, but figures without any explanations of what you measured precisely are useless. Given your comment and Julien's, I think I get a better overview of the 500ms your are hitting.