Closed
Bug 1091030
Opened 10 years ago
Closed 10 years ago
Remove mocha globals in mocha.setup() calls
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: kgrandon, Assigned: kgrandon)
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
These are no longer needed with JSHint work, and probably add a bit of extra time to the unit test runs as we discovered with past mocha.globals() usage. I think we should remove them.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8513562 [details] [review] Github pull request Hey Julien - I noticed that we still had these in the codebase after your lazy loader patch, and I don't think they're necessary anymore. Would you be comfortable reviewing the whole thing? I don't think it makes a lot of sense pulling in peers for this type of thing - it feels like it's test/linter infrastructure type of stuff. Thanks!
Attachment #8513562 -
Flags: review?(felash)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8513562 [details] [review] Github pull request r=me if it's green enough (and it looks like it is :) )
Attachment #8513562 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Thanks. Updated reviewer in commit, and landed: https://github.com/mozilla-b2g/gaia/commit/a0a9b5cfe43a5c2e5fc2b9cb94229932b9972fa3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•