1091058 - buggy rendering of text-decoration lines in vertical writing

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: textcase for underlining in vertical writing mode with multiple spans

The work in bug 1074735 to support text decoration lines in vertical writing mode was incomplete; it works for simple cases, but with more complex examples the lines end up misplaced (or missing). See attached testcase, where all the text in all three <div>s should be underlined.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Fix positioning of text-decoration lines in vertical writing mode.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Reftest for underlining of vertical writing-mode spans.

Here's the testcase in reftest form.

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 8513604 [details] [diff] [review]
Fix positioning of text-decoration lines in vertical writing mode.

Review of attachment 8513604 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ec811674d95
https://hg.mozilla.org/integration/mozilla-inbound/rev/aadd7fffaa99

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6ec811674d95
https://hg.mozilla.org/mozilla-central/rev/aadd7fffaa99