Closed Bug 1091067 Opened 10 years ago Closed 10 years ago

When using Software Home button, overflow menu button in browser chrome is difficult to tap in landscape mode

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:2.1+, b2g-v2.0 unaffected, b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
2.1 S8 (7Nov)
blocking-b2g 2.1+
Tracking Status
b2g-v2.0 --- unaffected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: jlee, Assigned: etienne)

References

()

Details

(Keywords: regression, Whiteboard: [2.1-exploratory-3][systemsfe])

Attachments

(2 files)

Attached file newwind_logcat.txt
Description:
With Software Home button turned on, attempting to tap the 'New window' button in the browser is difficult.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141027001201
2) On Homescreen, tap on Settings.
3) Scroll to Developer.
4) Select Developer.
5) Scroll to 'Window management' - Software home button.
6) Select 'Software home button'.
7) Exit to Homescreen.
8) Tap on Browser app.
9) Open any webpage.
10) Tilt device to landscape view.
11) Attempt to tap the 'New window' button (...) in upper right corner of browser.
12) Observe.
  
Actual:
When Software home button is being used the 'New window' button in browser is difficult to tap when in landscape mode. 
  
Expected: 
The 'New window' button in browser is easily tapped in landscape mode.
  
Environmental Variables:
Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141027001201
Gaia: c97463d61f45513a2123b19610386ddbfc916819
Gecko: 4f8c0c021128
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: This can also appear when not using Software home button. When Software Home button is used it is easier to see issue.
'New window' button appears to function properly when not in landscape mode.
  
Repro frequency: 2/3
See attached: video clip (http://youtu.be/RwRwL8sN6W8), logcat (newwind_logcat.txt)
-Issue occurs on 2.2 as well.

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029040208
Gaia: 35e87ac4324f0f3abd93dcc70d61c9f37256a0f5
Gecko: 7e3c85754d32
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


-Does not occur on 2.0 due to different design.
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
Component: Gaia::Browser → Gaia::System::Browser Chrome
Summary: [Browser] When using Software Home button, 'New Window' button in browser is difficult to tap in landscape mode → When using Software Home button, overflow menu button in browser chrome is difficult to tap in landscape mode
Etienne, this seems like it might be caused by the right hand side gesture-panel. If I reduce its width to 0 I can tap the overflow menu button without any problems.

It looks like the right hand panel is being set to 7rem rather than 2rem to make room for the software home button. Is it maybe extending further than it should?
Flags: needinfo?(etienne)
We have 2 solutions:

* The first, the "correct" one, is to use the plumbing already in place for this exact case (touch outside of the app iframe but not part of an edge gesture either): the 'edge-touch-redispatch' events. But it requires a non trivial amount of code since we end up doing hit-targeting in gaia. The SoftwareButtonManager uses this and would be a good source of inspiration.

* The second, the "cheap" one, it to make the edge zones' *height* smaller in this case. The width is set to cover the app iframe in the same way than in portrait (if you think of the shb as "hardware" the edge of the screen is on the app iframe :))
Flags: needinfo?(etienne)
[Blocking Requested - why for this release]:

Nominating this to block 2.1. This is very frustrating for the end user, basic functionality, and a regression
blocking-b2g: --- → 2.1?
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(dharris)
QA Contact: aalldredge
Whiteboard: [2.1-exploratory-3] → [2.1-exploratory-3][systemsfe]
Component: Gaia::System::Browser Chrome → Gaia::System
Broken functionality
blocking-b2g: 2.1? → 2.1+
Assignee: nobody → etienne
----------------------------------------------------
B2G-Inbound Regression Window (Shallow Flash)
----------------------------------------------------

Last Working:
Device: Flame 2.1
Build ID: 20140822191056
Gaia: 596040daa4312d4ba3acddd0dcc5304802ff7617
Gecko: 2ad58f6cfb8e
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

First Broken:
Device: Flame 2.1
Build ID: 20140823021656
Gaia: 2724945f7d474ebe0f3ecb29817ddd65f773fdf9
Gecko: a69dc0647dc3
Version: 34.0a1 (2.1)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 596040daa4312d4ba3acddd0dcc5304802ff7617
Gecko: a69dc0647dc3

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 2724945f7d474ebe0f3ecb29817ddd65f773fdf9
Gecko: 2ad58f6cfb8e

Pushlog:
https://github.com/mozilla-b2g/gaia/compare/596040daa4312d4ba3acddd0dcc5304802ff7617...2724945f7d474ebe0f3ecb29817ddd65f773fdf9

Caused by Bug 1047660
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(jmitchell)
Etienne - you are already assigned here so I won't bother with the NI - looks like this is broken by Bug 1047660
Blocks: 1047660
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(jmitchell)
QA Contact: aalldredge
Target Milestone: --- → 2.1 S8 (7Nov)
Attached file Gaia PR
Tried a bunch of alternatives and the simplest thing ended up yielding the best results :)
Just removing the code making the zone taller in landcape.

Tested with and without the SHB.

And no marionette since it's a landscape only change :/
Attachment #8517566 - Flags: review?(kgrandon)
Comment on attachment 8517566 [details] [review]
Gaia PR

Left a comment on github, but this looks good to me. Thanks!
Attachment #8517566 - Flags: review?(kgrandon) → review+
https://github.com/mozilla-b2g/gaia/commit/256e1c0d39b335efed3d4a908a4c149c6bd20c5a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Please request Gaia v2.1 approval on this patch when you get a chance.
Flags: needinfo?(etienne)
Verified the issue on Master 2.2 Flame
The 'New window' button in browser is easily tapped in landscape mode.

Device: Flame 2.2 Master
BuildID: 20141110040206
Gaia: 5f8206bab97cdd7b547cc2c8953cadb2a80a7e11
Gecko: d380166816dd
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
Status: RESOLVED → VERIFIED
Flags: needinfo?(ktucker)
Flags: needinfo?(ktucker)
Comment on attachment 8517566 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): edge gestures
[User impact] if declined: button seemingly broken in landscape
[Testing completed]: edge gestures + app chrome scenarios in landscape and portrait
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: none
Flags: needinfo?(etienne)
Attachment #8517566 - Flags: approval-gaia-v2.1?
Attachment #8517566 - Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
This issue is verified fixed on Flame 2.1.

Result: The 'New window' button responds properly when the user taps the button.

Device: Flame 2.1 (319mb, KK, Shallow Flash)
BuildID: 20141117001201
Gaia: 81160ad79e5b4c21967418dd63f1a1d08d77924e
Gecko: 3572aa3e6766
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: