Closed
Bug 1091091
Opened 10 years ago
Closed 10 years ago
Support ErrorResult in Promise::MaybeReject()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bkelly, Assigned: bkelly)
Details
Attachments
(1 file)
2.75 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Currently the only easy way to reject a promise with an ErrorResult is to let the binding code do it for you. Its not as simple as passing the error code from the ErrorResult into the promise because type errors need special handling. I need this for the Cache API, so I will get it working on maple first.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8513734 -
Flags: review?(bzbarsky)
Comment 2•10 years ago
|
||
Comment on attachment 8513734 [details] [diff] [review] Support ErrorResult in Promise::MaybeReject() Please document in ToJSValue.h that only a failed ErrorResult should be passed in? r=me
Attachment #8513734 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/12bba4eb1cef
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/12bba4eb1cef
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•