1091107 - Visual refinements in the tab strip

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Before I get a pretty picture...

Top padding: 8dp
Tab size: 40 dp

Font: 14sp Roboto, Light #777777

Comment 2

[Lucas Rocha (:lucasr)]

For reference:
https://bug1066253.bugzilla.mozilla.org/attachment.cgi?id=8493280

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Adding a note to clean up some of the numbers here, esp around tab overflow situations.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Visual refinements in the tab strip (r=mcomella)

Comment 5

[Lucas Rocha (:lucasr)]

Comment on attachment 8513834 [details] [diff] [review]
Visual refinements in the tab strip (r=mcomella)

Tweaked the specs to better snap to an 8dp grid.

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

Here's how it looks. I'll tweak the title font in a separate patch.

Comment 7

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8513836 [details]
Screenshot

Looking better!

separate issues to note: magnifying glass, and font (which you already mentioned :)

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8513834 [details] [diff] [review]
Visual refinements in the tab strip (r=mcomella)

Review of attachment 8513834 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lucas Rocha (:lucasr) from comment #5)
> Tweaked the specs to better snap to an 8dp grid.

This is in opposition to the spec in comment 2 - is this okay?

(In reply to Anthony Lam (:antlam) from comment #7)
> separate issues to note: magnifying glass

If you mean it's blurry, it should be fixed by bug 1077032.

Comment 9

[Lucas Rocha (:lucasr)]

(In reply to Michael Comella (:mcomella) from comment #8)
> Comment on attachment 8513834 [details] [diff] [review]
> Visual refinements in the tab strip (r=mcomella)
> 
> Review of attachment 8513834 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Lucas Rocha (:lucasr) from comment #5)
> > Tweaked the specs to better snap to an 8dp grid.
> 
> This is in opposition to the spec in comment 2 - is this okay?

As long as antlam approves the final result, that's fine :-)

Comment 10

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/5a85c6a1757b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a85c6a1757b

Comment 12

[Lucas Rocha (:lucasr)]

Discussed the font changes with antlam, decided to stick with regular type on tab strip items. Closing.