Closed Bug 1091107 Opened 7 years ago Closed 7 years ago

Visual refinements in the tab strip

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set
normal

Tracking

(firefox36 fixed)

RESOLVED FIXED
Firefox 36
Tracking Status
firefox36 --- fixed

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

(Whiteboard: [leave open])

Attachments

(2 files)

No description provided.
Before I get a pretty picture...

Top padding: 8dp
Tab size: 40 dp

Font: 14sp Roboto, Light #777777
Adding a note to clean up some of the numbers here, esp around tab overflow situations.
Comment on attachment 8513834 [details] [diff] [review]
Visual refinements in the tab strip (r=mcomella)

Tweaked the specs to better snap to an 8dp grid.
Attachment #8513834 - Flags: review?(michael.l.comella)
Attached image Screenshot
Here's how it looks. I'll tweak the title font in a separate patch.
Attachment #8513836 - Flags: feedback?(alam)
Comment on attachment 8513836 [details]
Screenshot

Looking better!

separate issues to note: magnifying glass, and font (which you already mentioned :)
Attachment #8513836 - Flags: feedback?(alam) → feedback+
Comment on attachment 8513834 [details] [diff] [review]
Visual refinements in the tab strip (r=mcomella)

Review of attachment 8513834 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Lucas Rocha (:lucasr) from comment #5)
> Tweaked the specs to better snap to an 8dp grid.

This is in opposition to the spec in comment 2 - is this okay?

(In reply to Anthony Lam (:antlam) from comment #7)
> separate issues to note: magnifying glass

If you mean it's blurry, it should be fixed by bug 1077032.
Attachment #8513834 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #8)
> Comment on attachment 8513834 [details] [diff] [review]
> Visual refinements in the tab strip (r=mcomella)
> 
> Review of attachment 8513834 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> (In reply to Lucas Rocha (:lucasr) from comment #5)
> > Tweaked the specs to better snap to an 8dp grid.
> 
> This is in opposition to the spec in comment 2 - is this okay?

As long as antlam approves the final result, that's fine :-)
Discussed the font changes with antlam, decided to stick with regular type on tab strip items. Closing.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.