1091110 - Dark lightweight themes have a thin light border on the top of the window in OSX

Status: NEW

(Firefox :: Theme, defect)

Description

[Brian Grinstead [:bgrins]]

Attachment: dark-lw-window-border.png

See screenshot - the window has a light border that can be seen against a dark background

Comment 1

[Brian Grinstead [:bgrins]]

Can be seen by applying this theme: https://addons.mozilla.org/en-US/firefox/addon/just-black/

Comment 2

[Brian Grinstead [:bgrins]]

Markus, any idea what might be causing this?

Comment 3

[Markus Stange [:mstange]]

If HWA is disabled, the system draws this highlight line on our window, and if HWA is enabled, we draw it ourselves. This is so that windows with a normal titlebar gradient match the native appearance.
With bright themes this looks good, but I agree that it looks bad with very dark themes.

Comment 4

[Brian Grinstead [:bgrins]]

(In reply to Markus Stange [:mstange] from comment #3)
> If HWA is disabled, the system draws this highlight line on our window, and
> if HWA is enabled, we draw it ourselves. This is so that windows with a
> normal titlebar gradient match the native appearance.
> With bright themes this looks good, but I agree that it looks bad with very
> dark themes.

So if HWA is enabled, would it be possible to not draw it in the case of a dark window background-color?