Open Bug 1091110 Opened 6 years ago Updated 6 years ago

Dark lightweight themes have a thin light border on the top of the window in OSX

Categories

(Firefox :: Theme, defect)

All
macOS
defect
Not set
normal

Tracking

()

People

(Reporter: bgrins, Unassigned)

Details

Attachments

(1 file)

See screenshot - the window has a light border that can be seen against a dark background
Can be seen by applying this theme: https://addons.mozilla.org/en-US/firefox/addon/just-black/
Markus, any idea what might be causing this?
Flags: needinfo?(mstange)
If HWA is disabled, the system draws this highlight line on our window, and if HWA is enabled, we draw it ourselves. This is so that windows with a normal titlebar gradient match the native appearance.
With bright themes this looks good, but I agree that it looks bad with very dark themes.
Flags: needinfo?(mstange)
(In reply to Markus Stange [:mstange] from comment #3)
> If HWA is disabled, the system draws this highlight line on our window, and
> if HWA is enabled, we draw it ourselves. This is so that windows with a
> normal titlebar gradient match the native appearance.
> With bright themes this looks good, but I agree that it looks bad with very
> dark themes.

So if HWA is enabled, would it be possible to not draw it in the case of a dark window background-color?
You need to log in before you can comment on or make changes to this bug.