Closed Bug 1091116 Opened 10 years ago Closed 10 years ago

Disable `autoreload` default in Commonplace

Categories

(Marketplace Graveyard :: Code Quality, defect)

Product:
Marketplace Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-11-04

People

(Reporter: cvan, Assigned: cvan)

Details

(Whiteboard: [qa-])

I spent the longest time trying to figure out why my browser kept reloading the page every time. I thought it was the dev tools/an extension. Turns it out it was this: https://github.com/mozilla/marketplace-gulp/blob/f546d4a/main.js#L207 If it actually reloaded a stylesheet when the CSS file changed, then that would be awesome. Feel free to make that happen, but have it be optional. Reloading the entire page anytime a file changes just isn't useful as a default.
https://github.com/mozilla/marketplace-gulp/commit/80c5408
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-11-04
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?(cvan)
Thanks. I've verified that it's working locally.
Status: RESOLVED → VERIFIED
Flags: needinfo?(cvan)
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.