1091128 - Max velocity cap only applies when scrolling downwards/rightwards

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

The velocity cap added in bug 976035 only caps the upper bound of velocities, not the lower bound. So when scrolling upwards/leftwards there is effectively no cap.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Take sign into consideration

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8513717 [details] [diff] [review]
Take sign into consideration

Review of attachment 8513717 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch!

::: gfx/layers/apz/src/Axis.cpp
@@ +48,5 @@
>    }
>  
>    float newVelocity = mAxisLocked ? 0.0f : (float)(mPos - aPos) / (float)(aTimestampMs - mPosTimeMs);
>    if (gfxPrefs::APZMaxVelocity() > 0.0f) {
> +    bool negative = (newVelocity < 0);

Let's call this 'velocityIsNegative'.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Updated variable name and landed:

https://hg.mozilla.org/integration/b2g-inbound/rev/08655880fafc

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/08655880fafc