Closed Bug 1091149 Opened 5 years ago Closed 5 years ago

Use of uninitialized value in string ne warnings from BugmailFilter extensiom

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dkl, Assigned: dkl)

Details

Attachments

(1 file, 1 obsolete file)

Lots of errors like this coming from the latest code push:

Use of uninitialized value in string ne at /loader/0x7f8ba6374ea8/Bugzilla/Extension/BugmailFilter/Filter.pm line 189.

https://errormill.mozilla.org/bugzilla/bmo/group/173904/
Summary: Use of uninitialized value in string ne errors from BugmailFilter extensiom → Use of uninitialized value in string ne warnings from BugmailFilter extensiom
Attached patch 1091149_1.patch (obsolete) — Splinter Review
Attachment #8513714 - Flags: review?(glob)
Comment on attachment 8513714 [details] [diff] [review]
1091149_1.patch

Review of attachment 8513714 [details] [diff] [review]:
-----------------------------------------------------------------

i don't think will fix the issue.

@$diffs always has field_name set; however the fake fields we insert for new attachments and comments do not.  a simple fix would be to set field_name to an empty string when adding the .created entries.
Attachment #8513714 - Flags: review?(glob) → review-
Attached patch 1091149_2.patchSplinter Review
Attachment #8513714 - Attachment is obsolete: true
Attachment #8515994 - Flags: review?(glob)
Attachment #8515994 - Flags: review?(glob) → review?(dylan)
Comment on attachment 8515994 [details] [diff] [review]
1091149_2.patch

Review of attachment 8515994 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8515994 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   4e1941f..44401a7  master -> master
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Component: Extensions: BugmailFilter → Extensions
You need to log in before you can comment on or make changes to this bug.