Created attachment 8513848 [details] logcat_20141029_1437.txt Description: If the user selects record with any Self-Timer option enabled the Camera UI and buttons will appear briefly. [None functional] Repro Steps: 1) Update a Flame device to BuildID: 20141029001202 2) Select Camera App 3) Select the drawer button. (Currently located to the top right. 4) Select Self-Timer 5) Select any delay option except for Off. 6) Back out to the Camera menu. 7) Switch to Video mode. 8) Press Record. 9) Observe the UI menu that appears briefly and then disappears. Actual: Camera UI menu with buttons appears and then disappears. Expected: It is expected that after pressing record the countdown will begin followed by the recording of the video with the additional UI buttons appearing. Environmental Variables: Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash) BuildID: 20141029001202 Gaia: eb0aab0f13c78c7ac378ad860e865c4b6eaf669f Gecko: 318019f80a8e Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 34.0 Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0 Repro frequency: 100% See attached: Logcat, Video Video: https://www.youtube.com/watch?v=xsDomldwTg0&list=UUluQpY8Ym6rXFSwAPn8mQow
This issue DOES occur on the Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash) and Flame 2.0 (319mb)(Kitkat Base)(Full Flash) Result: Camera UI with buttons briefly appears with no function before video begins recording. Environmental Variables: Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash) BuildID: 20141029040208 Gaia: 35e87ac4324f0f3abd93dcc70d61c9f37256a0f5 Gecko: 7e3c85754d32 Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 36.0a1 Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0 Environmental Variables: Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash) BuildID: 20141029000205 Gaia: 9f5b6f025e528fabfcc068782cb9b492cb51a7f9 Gecko: de8cfd54bf93 Gonk: 48835395daa6a49b281db62c50805bd6ca24077e Version: 32.0 Firmware: V188 User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
QA Whiteboard: [QAnalyst-Triage?]
This bug makes it seem like the recording is not working at all and could be very confusing to the end user. NI Camera owner to see if this is a blocker.
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(dharris) → needinfo?(npark)
[Blocking Requested - why for this release]: Noticed this as well, the camera UI continues to disappear and reappear throughout the recording, and the time indicator gets cropped periodically. Bad UI experience.
blocking-b2g: --- → 2.1?
Wilson or Diego, Can one of you take a look at this? Thanks Hema
Assignee: nobody → wilsonpage
I've had a look into this and it appears to be a graphics issue as: - Taking a screenshot of the broken UI doesn't show the bug - Selecting elements in the inspector and changing properties, causes them to flicker/show/hide. Mike, who is best to investigate this further?
Ah I think comment 5 is describing a different bug. I have managed to reproduce the original bug; working on a fix now.
CAUSE We weren't flagging the camera as 'recording' until the hardware had actually begun writing the video file. This meant that the UI remains unchanged for few 100ms. So between the timer finishing and the camera 'recording' there was a period of time where the UI switched back. FIX Flagging the camera as 'recording' as soon as the call the record is made ensures the UI updates instantly. This eliminates flicker of UI between timer-end and recording-start and generally makes the camera *feel* more responsive.
Created attachment 8517504 [details] [review] pull-request (master) Still got to add some tests.
Attachment #8517504 - Flags: review?(jdarcangelo)
Comment on attachment 8517504 [details] [review] pull-request (master) LGTM (minus the unrelated GFX glitches on master)
Attachment #8517504 - Flags: review?(jdarcangelo) → review+
Comment on attachment 8517504 [details] [review] pull-request (master) LANDED https://github.com/mozilla-b2g/gaia/commit/774e560f8079016199baeef861575492f2af75f7
Fixed on master. Guess we need to uplift now.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Triage decision: the settings menu shows for a split second and gets back into recording based on video -- Not worth blocking at this stage and based on triage criteria. Wilson, you could ask for approval request based on risk of patch. Thanks Hema
blocking-b2g: 2.1? → ---
You need to log in before you can comment on or make changes to this bug.