1091312 - Throw correct exceptions on AudioBufferSourceNode start() and stop()

Status: ASSIGNED

(Core :: Web Audio, defect, P3)

Description

[Paul Adenot (:padenot)]

Spec change: https://github.com/WebAudio/web-audio-api/issues/353

Comment 1

[Paul Adenot (:padenot)]

Attachment: MozReview Request: bz://1091312/padenot

Comment 2

[Paul Adenot (:padenot)]

/r/59 - Bug 1091312 - Throw InvalidAccessError when non-finite floats are passed to AudioBufferSourceNode.{start, stop}, or if offset is greater than the buffer length. r=ehsan

Pull down this commit:

hg pull review -r 25cae40162467a53f8ad9370722780386a0ba8c5

Comment 3

[Paul Adenot (:padenot)]

Attachment: Throw InvalidAccessError when non-finite floats are passed to AudioBufferSourceNode.{start, stop}, or if offset is greater than the buffer length

Trying the new stuff, do the review here if you're not adventurous, heh.

Comment 4

[(no longer active)]

https://reviewboard.mozilla.org/r/59/#review29

::: dom/media/webaudio/AudioBufferSourceNode.cpp
(Diff revision 1)
> +      (mBuffer && aOffset > mBuffer->Length() / mBuffer->SampleRate())) {

Nit: please wrap the greater than check in parentheses.

::: dom/media/webaudio/test/test_audioBufferSourceNodeParams.html
(Diff revision 1)
> +      s.start(-1);

Did you mean to also add a check for Infinity, as the comment suggests?

::: dom/media/webaudio/test/test_audioBufferSourceNodeParams.html
(Diff revision 1)
> +  [-1, buffer.duration + 1, NaN, Infinity].forEach(function(v) {

Please test -Infinity as well.

::: dom/media/webaudio/test/test_audioBufferSourceNodeParams.html
(Diff revision 1)
> +  [-1, Infinity, NaN].forEach(function(v) {

Here too.

::: dom/media/webaudio/test/test_audioBufferSourceNodeParams.html
(Diff revision 1)
> +  [-1, Infinity, NaN].forEach(function(v) {

And here.

::: dom/webidl/AudioBufferSourceNode.webidl
(Diff revision 1)
> -    void start(optional double when = 0, optional double grainOffset = 0,
> +    void start(optional unrestricted double when = 0, optional unrestricted double grainOffset = 0,

I assume you're going to change the spec accordingly too.

Comment 5

[(no longer active)]

https://reviewboard.mozilla.org/r/59/#review31

Ship It!

Comment 7

[Paul Adenot (:padenot)]

Attachment: MozReview Request: Bug 1091312 - Throw InvalidAccessError when non-finite floats are passed to AudioBufferSourceNode.{start, stop}, or if offset is greater than the buffer length. r=ehsan

Comment 8

[Maire Reavy [:mreavy]]

Paul - this is r+'d - what's blocking landing it?  Thanks

Comment 9

[Paul Adenot (:padenot)]

We need to talk at TPAC about this.

Comment 10

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.