1091484 - TEST-UNEXPECTED-FAIL | null | notification tests swipe up should hide the toast

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Comment 1

[Dale Harvey (:daleharvey)]

2 failing runs @ https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=61af5df504e1

Comment 2

[Dale Harvey (:daleharvey)]

This is the primary cause of our failures right now, I havent been able to reproduce locally, a waitFor may help but I would rather have someone who is familiar / responsible for that code to check it out, suggest disabling in the mean time

Comment 3

[Dale Harvey (:daleharvey)]

Alberto it looks like you have touched notifications a bunch recently, have you got any ideas?

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Disable intermittent test

Comment 5

[Alberto Pastor [:albertopq]]

Not sure, as is hard to repro locally, but I think I have an idea of what is causing this. Taking.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8514244 [details] [review]
Disable intermittent test

I won't review-, but I'll leave a F- because I think we should disable tests in the TBPL-manifest file from here on out.

Comment 7

[Dale Harvey (:daleharvey)]

The tbpl manifest can only have us disable the entire test file though, not individual tests, I also find it more confusing that we cant check the code to see what test is disabled why and have to cross reference failing tests with the test code and the manifest

I think tbpl manifest can go now that we dont support travis, but that aside in the case of disabling a single test using skip seems far more approriate than disabling all the tests

Comment 8

[Kevin Grandon :kgrandon]

Disabling in the manifest makes the current disabled bugs much easier to digest/triage. I think it will also raise the urgency of re-enabling the test. If disabling multiple tests in a file is a problem, then I think there are too many tests in that file to begin with.

The new recommended practice is one or very few tests per file, in order to best take advantage of chunking.

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 8514244 [details] [review]
Disable intermittent test

Clearing review, Alberto is looking at this, agreed with kevin on vidyo that if this isnt fixed by end of day, will disable via tbpl manifest

Comment 10

[Alberto Pastor [:albertopq]]

Can't see anymore this error on the reports. About 50% failed because of [1] thought:

[1] command timed out: 

1800 seconds without output running ['/tools/buildbot/bin/python', 'scripts/scripts/gaia_integration.py', '--cfg', 'b2g/gaia_integration_config.py', '--this-chunk', '3', '--total-chunks', '4', '-c', 'b2g/gaia_try.py', '-c', u'http://hg.mozilla.org/integration/gaia-try/raw-file/7c3dfdaf9b33d5726a50dd535f47d67716f1ef17/linux64.json', '--download-symbols', 'ondemand'], attempting to kill

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=7c3dfdaf9b33

What do you think?

Comment 11

[Etienne Segonzac (:etienne)]

Fly-by-note: going to "0" might not be enough depending on where the drag starts, we might want to go -30px to be sure there's nothing left to transition of screen.

Comment 12

[Dale Harvey (:daleharvey)]

I triggered it another 9 times to be certain but looks good by me, those failures are unrelated

Comment 13

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/25660

Comment 14

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/d0ed457f082d6cf107b82e7b632c0a6ad690ebaf

Comment 15

[Dale Harvey (:daleharvey)]

Still seeing this

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=dc3c998d2358

Comment 16

[Dale Harvey (:daleharvey)]

Disabled in https://github.com/mozilla-b2g/gaia/commit/02972fa3d48b2bdb84f901ff604355271ecad4da

Comment 17

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26529

Seems pretty stable now. What do you think?

Comment 18

[Dale Harvey (:daleharvey)]

Comment on attachment 8529773 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26529

Sorry for the delay, I was on PTO + travelling, but this is looking good cheers

Comment 19

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/1ada7517031c5177264c1a086d05109ace0d2d96