Closed Bug 1091504 Opened 9 years ago Closed 9 years ago

[B2G][GAIA] STK: AP should not send TR for STK_CMD_REFRESH.

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Settings
Platform:
ARM
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0M+, b2g-v2.0 affected, b2g-v2.0M fixed, b2g-v2.1 affected, b2g-v2.2 fixed)

Status:
RESOLVED FIXED
Milestone:
2.1 S9 (21Nov)
Project Flags:
blocking-b2g 2.0M+
Tracking Flags:
Tracking Status
b2g-v2.0 --- affected
b2g-v2.0M --- fixed
b2g-v2.1 --- affected
b2g-v2.2 --- fixed

People

(Reporter: sku, Assigned: mancas)

References

Details

Attachments

(3 files)

Patch v2.0m
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
Patch master
46 bytes, text/x-github-pull-request
timdream
: review+
Details | Review
Patch v2.1
46 bytes, text/x-github-pull-request
Details | Review
blocking-b2g: --- → 2.0M?
Blocks: Woodduck
Assignee: nobody → b.mcb
blocking-b2g: 2.0M? → 2.0M+
status-b2g-v2.0: --- → affected
status-b2g-v2.0M: --- → affected
status-b2g-v2.1: --- → affected
status-b2g-v2.2: --- → affected
Attached file Patch v2.0m — 

        Attachment #8514915 -
        Flags: review?(timdream)

    
    

    
  
Comment on attachment 8514915 [details] [review]
Patch v2.0m

Don't we need a master patch?

        Attachment #8514915 -
        Flags: review?(timdream) → review+

    
    

    
  

      
      
      
      

        Attached file
          
        Patch master
        — 
      

    


  

    
    

    
  

      
      
      
      

        Attached file
          
        Patch v2.1
        — 
      

    


  

    
    

    
  
Comment on attachment 8515799 [details] [review]
Patch master

Hey Tim, please take a quick look at the patches, since I've changed the unit test related to the STK_CMD_REFRESH command

Thanks

        Attachment #8515799 -
        Flags: review?(timdream)

        Attachment #8515799 -
        Flags: review?(timdream) → review+

    
    

    
  
Asking for checkin in master branch
Keywords: checkin-needed

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/4b84873a4bef3e1d37515e0363a931a561aa8adb
Status: NEW → RESOLVED
Closed: 9 years ago

          status-b2g-v2.2:
          affected → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)

          You need to log in
          before you can comment on or make changes to this bug.