Telephony marionette tests fails in test_audiomanager_phonestate.js and test_incomingcall_phonestate_speaker.js

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: edgar, Assigned: aknow)

Tracking

unspecified
2.1 S8 (7Nov)
x86_64
Linux
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Comment 1

4 years ago
test_audiomanager_phonestate.js :
> 00:54:59     INFO -  10-30 07:16:22.015 I/Gecko   (   44): MARIONETTE LOG: INFO: Remote hanging up the call.
> 00:54:59     INFO -  10-30 07:16:22.245 I/Gecko   (   44): MARIONETTE LOG: INFO: Received 'disconnected' call event.
> 00:54:59     INFO -  10-30 07:16:22.255 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | event.call - [object TelephonyCall] should equal [object TelephonyCall]
> 00:54:59     INFO -  10-30 07:16:22.255 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | call state - disconnected should equal disconnected
> 00:54:59     INFO -  10-30 07:16:22.265 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - false should equal false
> 00:54:59     INFO -  10-30 07:16:22.275 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> 00:54:59     INFO -  10-30 07:16:22.305 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - true should equal true
> 00:54:59     INFO -  10-30 07:16:22.315 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> 00:54:59     INFO -  10-30 07:16:22.335 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - false should equal false
> 00:54:59     INFO -  10-30 07:16:22.345 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> ...

test_incomingcall_phonestate_speaker.js :
> 00:55:06     INFO -  10-30 07:18:38.376 I/Gecko   (   44): MARIONETTE LOG: INFO: Received 'disconnected' call event.
> 00:55:06     INFO -  10-30 07:18:38.385 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_incomingcall_phonestate_speaker.js | event.call - [object TelephonyCall] should equal [object TelephonyCall]
> 00:55:06     INFO -  10-30 07:18:38.385 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_incomingcall_phonestate_speaker.js | call state - disconnected should equal disconnected
> 00:55:06     INFO -  10-30 07:18:38.405 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_incomingcall_phonestate_speaker.js | audioManager.phoneState - got 2, expected 0
> 00:55:06     INFO -  10-30 07:18:38.425 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_incomingcall_phonestate_speaker.js | audioManager.phoneState - got 2, expected 0
> ...

Looks like something related to call drop and audioManager.
(Assignee)

Updated

4 years ago
Assignee: nobody → szchen
(Assignee)

Comment 2

4 years ago
Created attachment 8514232 [details] [diff] [review]
Part 1: Notify callDisconnected after audioStateChanged

Race condition.
Original code is not wrong. Just change it to match our test code.
Attachment #8514232 - Flags: review?(htsai)
(Assignee)

Comment 3

4 years ago
Created attachment 8514233 [details] [diff] [review]
Part 2: Correct test: Speaker setting should not affect audio state
Attachment #8514233 - Flags: review?(htsai)
(Assignee)

Comment 4

4 years ago
Created attachment 8514235 [details] [diff] [review]
Part 1#2: Notify callDisconnected after audioStateChanged
Attachment #8514232 - Attachment is obsolete: true
Attachment #8514232 - Flags: review?(htsai)
Attachment #8514235 - Flags: review?(htsai)
(Assignee)

Comment 5

4 years ago
ni myself to correct the test case
Flags: needinfo?(szchen)

Updated

4 years ago
Attachment #8514233 - Flags: review?(htsai) → review+
Comment on attachment 8514235 [details] [diff] [review]
Part 1#2: Notify callDisconnected after audioStateChanged

Review of attachment 8514235 [details] [diff] [review]:
-----------------------------------------------------------------

Works well.
Attachment #8514235 - Flags: review?(htsai) → review+
(Assignee)

Comment 7

4 years ago
Created attachment 8514893 [details] [diff] [review]
Part 2#2: Correct test case

Modify the test. Now, we could pass the test even without applying part 1 patch. But I still plan to land the part 1 along with this change.
Attachment #8514233 - Attachment is obsolete: true
Flags: needinfo?(szchen)
Attachment #8514893 - Flags: review?(htsai)
Comment on attachment 8514893 [details] [diff] [review]
Part 2#2: Correct test case

Review of attachment 8514893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_incomingcall_phonestate_speaker.js
@@ -1,1 @@
> -/* Any copyright is dedicated to the Public Domain.

Thanks for the clean up.
Attachment #8514893 - Flags: review?(htsai) → review+
https://hg.mozilla.org/mozilla-central/rev/2af85149315f
https://hg.mozilla.org/mozilla-central/rev/28b3c944c705
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in before you can comment on or make changes to this bug.