1091551 - Telephony marionette tests fails in test_audiomanager_phonestate.js and test_incomingcall_phonestate_speaker.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

full log: http://ftp.mozilla.org/pub/mozilla.org/b2g/try-builds/[e-mail]-29bef366dd77/try-emulator/try_ubuntu64_vm-b2g-emulator_test-marionette-webapi-bm52-tests1-linux64-build1014.txt.gz

I can reproduce this with latest emulator + m-c. :(

Comment 1

[Edgar Chen [:edgar]]

test_audiomanager_phonestate.js :
> 00:54:59     INFO -  10-30 07:16:22.015 I/Gecko   (   44): MARIONETTE LOG: INFO: Remote hanging up the call.
> 00:54:59     INFO -  10-30 07:16:22.245 I/Gecko   (   44): MARIONETTE LOG: INFO: Received 'disconnected' call event.
> 00:54:59     INFO -  10-30 07:16:22.255 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | event.call - [object TelephonyCall] should equal [object TelephonyCall]
> 00:54:59     INFO -  10-30 07:16:22.255 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | call state - disconnected should equal disconnected
> 00:54:59     INFO -  10-30 07:16:22.265 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - false should equal false
> 00:54:59     INFO -  10-30 07:16:22.275 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> 00:54:59     INFO -  10-30 07:16:22.305 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - true should equal true
> 00:54:59     INFO -  10-30 07:16:22.315 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> 00:54:59     INFO -  10-30 07:16:22.335 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_audiomanager_phonestate.js | telephony.speakerEnabled - false should equal false
> 00:54:59     INFO -  10-30 07:16:22.345 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_audiomanager_phonestate.js | audioManager.phoneState - got 2, expected 0
> ...

test_incomingcall_phonestate_speaker.js :
> 00:55:06     INFO -  10-30 07:18:38.376 I/Gecko   (   44): MARIONETTE LOG: INFO: Received 'disconnected' call event.
> 00:55:06     INFO -  10-30 07:18:38.385 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_incomingcall_phonestate_speaker.js | event.call - [object TelephonyCall] should equal [object TelephonyCall]
> 00:55:06     INFO -  10-30 07:18:38.385 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-PASS | test_incomingcall_phonestate_speaker.js | call state - disconnected should equal disconnected
> 00:55:06     INFO -  10-30 07:18:38.405 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_incomingcall_phonestate_speaker.js | audioManager.phoneState - got 2, expected 0
> 00:55:06     INFO -  10-30 07:18:38.425 I/Gecko   (   44): MARIONETTE TEST RESULT:TEST-UNEXPECTED-FAIL | test_incomingcall_phonestate_speaker.js | audioManager.phoneState - got 2, expected 0
> ...

Looks like something related to call drop and audioManager.

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Notify callDisconnected after audioStateChanged

Race condition.
Original code is not wrong. Just change it to match our test code.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: Correct test: Speaker setting should not affect audio state

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1#2: Notify callDisconnected after audioStateChanged

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

ni myself to correct the test case

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8514235 [details] [diff] [review]
Part 1#2: Notify callDisconnected after audioStateChanged

Review of attachment 8514235 [details] [diff] [review]:
-----------------------------------------------------------------

Works well.

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2#2: Correct test case

Modify the test. Now, we could pass the test even without applying part 1 patch. But I still plan to land the part 1 along with this change.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8514893 [details] [diff] [review]
Part 2#2: Correct test case

Review of attachment 8514893 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/telephony/test/marionette/test_incomingcall_phonestate_speaker.js
@@ -1,1 @@
> -/* Any copyright is dedicated to the Public Domain.

Thanks for the clean up.

Comment 9

[Szu-Yu Chen [:aknow] (inactive)]

try
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3f8c75d6bc7f

Comment 10

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/2af85149315f
https://hg.mozilla.org/integration/b2g-inbound/rev/28b3c944c705

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2af85149315f
https://hg.mozilla.org/mozilla-central/rev/28b3c944c705