1091601 - Settings closes down when changing permissions for THA applications

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Fredrik Lanker [:lanker]]

Step to reproduce:

1. Make sure some trusted hosted application is installed
2. Go to Settings -> App permissions
3. Pick a trusted hosted application
4. Try to change permissions

result: Settings closes down

Comment 1

[Fredrik Lanker [:lanker]]

Attachment: Bug_1091601-Settings_closes_down_when_changing_permissions_for_THA_applications.patch

Comment 2

[Fredrik Lanker [:lanker]]

Application kind is used in isExplicitInPermissionsTable for checking the permissions in the permission table. When calling the function from PermissionSettings, the app kind wasn't passed so the permission check failed. This lead to Settings closing down when trying to change the permissions in "App permissions", due to the assert in receiveMessage (dom/permission/PermissionSettings.jsm).

The attached patch fixes this.

Comment 3

[Mikael Niklasson]

[Blocking Requested - why for this release]:

This is of vital importance for Trusted Hosted Apps.

Comment 4

[bhavana bajaj [:bajaj]]

Blocking given THA is shipping in 2.1 and the impact here.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/82c351b0cf67

Comment 6

[bhavana bajaj [:bajaj]]

kwierso, can you help merge this on 2.1? Its unclear if this is on m-c yet, but prolly you can help confirm.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to bhavana bajaj [:bajaj] from comment #6)
> kwierso, can you help merge this on 2.1? Its unclear if this is on m-c yet,
> but prolly you can help confirm.

So this did merge to m-c back around when it first landed to b2g-inbound. Unsure why it wasn't commented/resolved, then.

Pushed this to b2g34 as well in https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152

My understanding is that this does not need to be pushed to Aurora 35 (no b2g releases will be based on 35) or Beta 34 (the b2g34 relbranch is sufficient).

Happy to push it more places if my understanding is incorrect. :)

Comment 8

[Elie]

Attachment: VIDEO0050_Compress.MP4

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        1b231b87aad384842dfc79614b2a9ca68a4b4ff3
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/95fbd7635152
Build-ID        20141119001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2

Comment 9

[Coler]

This bug has been verified as "pass" on latest build of Flame 2.2, Nexus5_2.2 by STR as comment 0.


Actual result:It will keep in settings view when we change permissions in App permissions view.

See attachment:Verify.3gp
Reproducing rate: 0/5


Device:Nexus5_2.2 build(Pass):
Build ID               20150615002503
Gaia Revision          e7a0c6d5f4df04d45fb3f726efb9e8223600cb79
Gaia Date              2015-06-15 06:12:18
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f278c675d51f
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150615.040818
Firmware Date          Mon Jun 15 04:08:47 EDT 2015
Bootloader             HHZ12d

Device:Flame 2.2 build(Pass):
Build ID               20150615002503
Gaia Revision          e7a0c6d5f4df04d45fb3f726efb9e8223600cb79
Gaia Date              2015-06-15 06:12:18
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f278c675d51f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150615.040806
Firmware Date          Mon Jun 15 04:08:18 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Coler]

Attachment: Verify.3gp