|mach gtest| does not display the test result at all

RESOLVED FIXED in mozilla36

Status

()

Toolkit
Startup and Profile System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emk, Assigned: emk)

Tracking

unspecified
mozilla36
x86_64
Windows 8.1
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Steps to reproduce:
  mach gtest

Actual result:
xul.dll will be relinked, but no further output after the following line:
 0:59.51 g:\m\mozilla-central\obj-i686-pc-mingw32\dist\bin\firefox.exe -unittest

Expected result:
The test result should be displayed.

|mozmake -C obj-i686-pc-mingw32/testing/gtest/| check works, but it does not relink xul.dll automatically. My workaround is |mach gtest| then |mozmake -C .../gtest/ check|.
(Assignee)

Comment 1

4 years ago
  MOZ_RUN_GTEST=1 obj-i686-pc-mingw32/dist/bin/firefox.exe -unittest
had no display either, but
  MOZ_RUN_GTEST=1 obj-i686-pc-mingw32/dist/bin/firefox.exe -unittest | cat
worked.
Oh, this is probably just another manifestation of the "Windows console doesn't attach" problem. If you pipe stdout it works around it. Presumably running make check is piping the output but the mach command isn't.
(Assignee)

Comment 3

4 years ago
|make check| uses rungtest.py. Bug 1050878 will help.
Depends on: 1050878
(Assignee)

Comment 4

4 years ago
Created attachment 8515027 [details] [diff] [review]
Attach the console if the process is running the GTest

I don't think bug 787313 is a problem for the gtest mode.
The gtest mode is itself opt-in, is disabled in the shipped binaries, and will not even create a window.
I also fixed a bug that the -attach-console option didn't work correctly.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Attachment #8515027 - Flags: review?(ted)
(Assignee)

Updated

4 years ago
Component: mach → Startup and Profile System
No longer depends on: 1050878
Product: Core → Toolkit
(Assignee)

Comment 5

4 years ago
Try result:
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=74710eb67527
(gtest is running under "B".)
Comment on attachment 8515027 [details] [diff] [review]
Attach the console if the process is running the GTest

Review of attachment 8515027 [details] [diff] [review]:
-----------------------------------------------------------------

This makes sense, thanks.
Attachment #8515027 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/8d2c268b9063
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.