TEST-UNEXPECTED-FAIL | null | net_error.html: in an iframe

RESOLVED FIXED in 2.1 S8 (7Nov)

Status

Firefox OS
Gaia
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: daleharvey, Assigned: mikehenrty)

Tracking

unspecified
2.1 S8 (7Nov)
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
6 out of 20 fails @ https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=1dfd3cd6a9fc
(Reporter)

Updated

3 years ago
Blocks: 960072
Assignee: nobody → mhenretty
Created attachment 8514674 [details] [review]
[Gaia PR] wait for system to load

When I ran this test locally, I was seeing weird errors related to bootstrap.js. Making this test wait for the system to finish booting before starting the net error test seems to fix the intermittent issue here.

https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=b1c39ace18fc

Kevin, wanna have a look?
Attachment #8514674 - Flags: review?(kgrandon)
Comment on attachment 8514674 [details] [review]
[Gaia PR] wait for system to load

Sure, waitForStartup() is pretty common, so that usage seems fine to me. I wonder if we should just put something like this directly into the testing framework.

I left a few comments on github.
Attachment #8514674 - Flags: review?(kgrandon) → review+
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
master: https://github.com/mozilla-b2g/gaia/commit/9f0d958838c16a73e0064ec70302254171e83c05
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(In reply to Kevin Grandon :kgrandon from comment #2)
> Sure, waitForStartup() is pretty common, so that usage seems fine to me. I
> wonder if we should just put something like this directly into the testing
> framework.

+1
You need to log in before you can comment on or make changes to this bug.