Run toplevel::base on win2k8

RESOLVED FIXED

Status

Infrastructure & Operations
RelOps: Puppet
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: dustin, Assigned: dustin)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/613] )

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
There are just a few small tweaks left to make catalogs compile on windows.
(Assignee)

Updated

3 years ago
Depends on: 1048962
No longer depends on: 1050343

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/613]
(Assignee)

Comment 1

3 years ago
Created attachment 8514333 [details] [diff] [review]
bug1091663.patch

This requires https://bugzilla.mozilla.org/show_bug.cgi?id=1048962, which you should land soon :)
Attachment #8514333 - Flags: review?(mcornmesser)
(Assignee)

Comment 2

3 years ago
Comment on attachment 8514333 [details] [diff] [review]
bug1091663.patch

Review of attachment 8514333 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/users/manifests/root.pp
@@ +24,4 @@
>  
>      $home = $::operatingsystem ? {
>          Darwin => '/var/root',
> +        Windows => 'C:\Users\Administrator',  # $rlocalpath,

I need help with this part.  $rlocalpath is empty on my test box, so this ends up an empty string and Puppet fails trying to install /.hgrc.  Any idea why?
Created attachment 8514430 [details]
winrootlp.rb

The current version of winrootlp.rb in HG isn't functioning correctly. It had kind of dropped lower on my list. This version works, but i remeber something about it not being very clean code.
(Assignee)

Comment 4

3 years ago
Let's get a bug open for that, too, blocking this one.
Depends on: 1091834
Comment on attachment 8514333 [details] [diff] [review]
bug1091663.patch

Review of attachment 8514333 [details] [diff] [review]:
-----------------------------------------------------------------

With winrootlp.rb working I would like to stay with $rlocalpath.
Attachment #8514333 - Flags: review?(mcornmesser) → review-
(Assignee)

Updated

3 years ago
Depends on: 1085468
(Assignee)

Comment 6

3 years ago
Created attachment 8515033 [details] [diff] [review]
bug1091663-r2.patch

This assumes winrootlp (bug 1091834) and the extra ' in execonce (bug 1085468) are fixed, as well as the packages::pkgzip define (bug 1048962).
Attachment #8514333 - Attachment is obsolete: true
Attachment #8514430 - Attachment is obsolete: true
Attachment #8515033 - Flags: review?(mcornmesser)
(Assignee)

Updated

3 years ago
Blocks: 1036999
Attachment #8515033 - Flags: review?(mcornmesser) → review+

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/613] [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1391] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1391] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1392] [kanban:engops:https://kanbanize.com/ctrl_board/6/613]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1392] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1394] [kanban:engops:https://kanbanize.com/ctrl_board/6/613]

Updated

3 years ago
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1394] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1401] [kanban:engops:https://kanbanize.com/ctrl_board/6/613]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/1401] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/613] [kanban:engops:https://kanbanize.com/ctrl_board/6/613]
(Assignee)

Updated

3 years ago
Depends on: 1095483
(Assignee)

Comment 7

3 years ago
Created attachment 8519152 [details] [diff] [review]
bug1091663-r3.patch

Updated version of the patch after other prereqs have been elimiated; carrying forward the r+
Attachment #8515033 - Attachment is obsolete: true
Attachment #8519152 - Flags: review+
(Assignee)

Updated

3 years ago
Blocks: 979540
(Assignee)

Updated

3 years ago
No longer depends on: 1095483, 1048962, 1085468, 1091834
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/613] [kanban:engops:https://kanbanize.com/ctrl_board/6/613] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/613]
(Assignee)

Comment 8

3 years ago
http://hg.mozilla.org/build/puppet/rev/ce16896387de
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.