Closed Bug 1091679 Opened 10 years ago Closed 10 years ago

Update tests to wait for the plivo call to end

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Bebe, Assigned: Bebe)

Details

Attachments

(2 files)

Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657
46 bytes, text/x-github-pull-request
viorela
: review+
jlorenzo
: review+
Details | Review
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/26590
46 bytes, text/x-github-pull-request
RobertC
: review+
Bebe
: review+
Details | Review 
We don't change the plivo status after we make the call.

Add the code to update the call status

        Attachment #8514347 -
        Flags: review?(zcampbell)

        Attachment #8514347 -
        Flags: review?(viorela.ioia)

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

r+

        Attachment #8514347 -
        Flags: review?(zcampbell) → review+

    
  
QA Whiteboard: fxosqa-auto-from-s2

    
  
QA Whiteboard: fxosqa-auto-from-s2 → fxosqa-auto-from-s2, fxosqa-auto-s3

    
  
QA Whiteboard: fxosqa-auto-from-s2, fxosqa-auto-s3 → [fxosqa-auto-from-s2] [fxosqa-auto-s3]

    
  
Assignee: nobody → florin.strugariu

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

r+, should we add this wait to test_dialer_miss_call_from_known_contact_notification.py
Flags: needinfo?(florin.strugariu)

        Attachment #8514347 -
        Flags: review?(viorela.ioia) → review+

    
  
Flags: needinfo?(florin.strugariu)
Summary: Update test_receive_call_with_locked_screen to wait for the plivo call to end → Update tests to wait for the plivo call to end

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

I made more changes to this pull so we need a new review

        Attachment #8514347 -
        Flags: review?(zcampbell)

        Attachment #8514347 -
        Flags: review?(viorela.ioia)

        Attachment #8514347 -
        Flags: review+

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

I'm redirecting my r? to Jlorenzo as he's the plivo expert and wrote some of these tests.

        Attachment #8514347 -
        Flags: review?(zcampbell) → review?(jlorenzo)

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

We're close! I left my comment on the PR.

        Attachment #8514347 -
        Flags: review?(jlorenzo) → review-

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

Updated

        Attachment #8514347 -
        Flags: review- → review?(jlorenzo)

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

Just a small comment which is not true anymore to remove, and that's good for me.

        Attachment #8514347 -
        Flags: review?(jlorenzo) → review+

    
    

    
  
Fixed

    
    

    
  
Comment on attachment 8514347 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/25657

r+

        Attachment #8514347 -
        Flags: review?(viorela.ioia) → review+

    
    

    
  
merging this as it has 2 reviews.

https://github.com/mozilla-b2g/gaia/commit/179178746505a13de425ebeb059edcbc4749289c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
We need this in v2.1 too.
Test test_dialer_receive_call_with_locked_screen.py has failed in latest v2.1 build because it is not waiting for the call to be completed. 
I'll open a PR with the uplift
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  

        Attachment #8531214 -
        Flags: review?(robert.chira)

        Attachment #8531214 -
        Flags: review?(florin.strugariu)

        Attachment #8531214 -
        Flags: review?(robert.chira) → review+

    
  

        Attachment #8531214 -
        Flags: review?(florin.strugariu) → review+

    
    

    
  
https://github.com/mozilla-b2g/gaia/commit/a684b82a19dd1939ca6e75e60a6203327b333c2a
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: