If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

history tests folder should be one level higher

RESOLVED FIXED in mozilla36

Status

()

Toolkit
Places
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mak, Assigned: awake, Mentored)

Tracking

Trunk
mozilla36
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
the history folder for history.remove test has been created under unit/, it should have been created under tests/ like all of the other folders (bookmarks, autocomplete, ...)

I should have noticed this detail in the review.
Basically, the idea is to move http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history/unit/. A few moz.build files will need to be updated.
Mentor: dteller@mozilla.com
Whiteboard: [lang=js][good first bug]
(Reporter)

Comment 2

3 years ago
(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #1)
> Basically, the idea is to move
> http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> tests/unit/history to toolkit/components/places/tests/history/unit/

nope, we should move toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history
(Assignee)

Comment 3

3 years ago
Hi, I'd like to work on this as my first bug. Could someone assign this bug to me?
(Assignee)

Comment 4

3 years ago
Created attachment 8523492 [details] [diff] [review]
bug1091693.diff
Attachment #8523492 - Flags: review?(dteller)
Assignee: nobody → bugzillafx
Comment on attachment 8523492 [details] [diff] [review]
bug1091693.diff

Review of attachment 8523492 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Let's see the results on Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f0ea42cfdeee
Attachment #8523492 - Flags: review?(dteller) → review+
(Assignee)

Comment 6

3 years ago
Created attachment 8525259 [details] [diff] [review]
Added reviewer to commit message
Attachment #8523492 - Attachment is obsolete: true
Attachment #8525259 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/591274235907
Keywords: checkin-needed
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/591274235907
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][good first bug][fixed-in-fx-team] → [lang=js][good first bug]
Target Milestone: --- → mozilla36
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.