Closed Bug 1091693 Opened 5 years ago Closed 5 years ago

history tests folder should be one level higher

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: mak, Assigned: awake, Mentored)

References

Details

(Whiteboard: [lang=js][good first bug])

Attachments

(1 file, 1 obsolete file)

the history folder for history.remove test has been created under unit/, it should have been created under tests/ like all of the other folders (bookmarks, autocomplete, ...)

I should have noticed this detail in the review.
Basically, the idea is to move http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history/unit/. A few moz.build files will need to be updated.
Mentor: dteller
Whiteboard: [lang=js][good first bug]
(In reply to David Rajchenbach-Teller [:Yoric] (use "needinfo") from comment #1)
> Basically, the idea is to move
> http://dxr.mozilla.org/mozilla-central/source/toolkit/components/places/
> tests/unit/history to toolkit/components/places/tests/history/unit/

nope, we should move toolkit/components/places/tests/unit/history to toolkit/components/places/tests/history
Hi, I'd like to work on this as my first bug. Could someone assign this bug to me?
Attached patch bug1091693.diff (obsolete) — Splinter Review
Attachment #8523492 - Flags: review?(dteller)
Assignee: nobody → bugzillafx
Comment on attachment 8523492 [details] [diff] [review]
bug1091693.diff

Review of attachment 8523492 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Let's see the results on Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=f0ea42cfdeee
Attachment #8523492 - Flags: review?(dteller) → review+
Attachment #8523492 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/591274235907
Keywords: checkin-needed
Whiteboard: [lang=js][good first bug] → [lang=js][good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/591274235907
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js][good first bug][fixed-in-fx-team] → [lang=js][good first bug]
Target Milestone: --- → mozilla36
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.