Closed Bug 1091714 Opened 10 years ago Closed 10 years ago

Alarm icon sits up too high in status bar

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: pabratowski, Assigned: pivanov)

References

Details

(Whiteboard: UX Quality)

Attachments

(4 files, 1 obsolete file)

Attached image 2014-10-29-09-32-42.png
It looks like the alarm icon is a few pixels too high in the status bar when you compare it to the other status bar icons.
Assignee: nobody → epang
Blocks: 1069288
Whiteboard: UX Quality
Attached file Status Bar Icon Sprites (obsolete) —
Hey Can you help update the sprites?  I moved the alarm icon a tiny bit up.  Can you flag me for UI-Review when ready so I can check the spacing?  Thanks!
Flags: needinfo?(pivanov)
Assignee: epang → pivanov
Attached file patch for Gaia/master
Sure :)

can you ui-r?
Flags: needinfo?(pivanov)
Attachment #8524049 - Flags: ui-review?(epang)
(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #2)
> Created attachment 8524049 [details] [review]
> patch for Gaia/master
> 
> Sure :)
> 
> can you ui-r?

Hey Pavel, can you send me a screen shot?  I just tested and the icons is in the same position so I'm not sure if it's something to do with the sprites or my flashing.  Thanks!
Flags: needinfo?(pivanov)
Attached image Shot from Device
Flags: needinfo?(pivanov)
Attachment #8525533 - Flags: ui-review?(epang)
Attached file Sprites.zip
let's try this again.. but this time in the right direction!
Attachment #8523914 - Attachment is obsolete: true
Flags: needinfo?(pivanov)
Comment on attachment 8524049 [details] [review]
patch for Gaia/master

Looks good now, thanks Pavel!
Attachment #8524049 - Flags: ui-review?(epang) → ui-review+
Flags: needinfo?(pivanov)
Attachment #8524049 - Flags: review+
Landed to master:
https://github.com/mozilla-b2g/gaia/commit/dc1a6648e0bde12f75583026d53d2b76d103e1b2
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8525533 - Flags: ui-review?(epang)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: