Closed Bug 1091719 Opened 10 years ago Closed 10 years ago

When setting a new alarm the header text is not centered

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pabratowski, Assigned: pivanov)

References

Details

(Whiteboard: UX Quality)

Attachments

(3 files)

2014-10-29-09-32-20.png
39.07 KB, image/png
Details
patch for Gaia/master
46 bytes, text/x-github-pull-request
wilsonpage
: review+
HHuang
: ui-review+
Details | Review
patch for Gaia/master
46 bytes, text/x-github-pull-request
Details | Review
Attached image 2014-10-29-09-32-20.png — 
      No description provided.
The header font is not centered in the create new alarm screen.
Assignee: nobody → hhuang
Blocks: 1069288
Whiteboard: UX Quality
Assignee: hhuang → pivanov
Attached file patch for Gaia/master — 
hey Hellen ... I saw this one and I fixed it :) can you ui-r? it :)
Attachment #8526984 - Flags: ui-review?(hhuang)
Comment on attachment 8526984 [details] [review]
patch for Gaia/master

Hi Pavel, it looks good! Thanks for helping on this bug :)
Attachment #8526984 - Flags: ui-review?(hhuang) → ui-review+
Attachment #8526984 - Flags: review?(wilsonpage)
Attachment #8526984 - Flags: review?(wilsonpage) → review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/401691e6ba9bb8a5f99ec33e87b7010826a262df
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
reverted for test failures like https://treeherder.mozilla.org/ui/logviewer.html#?job_id=891332&repo=b2g-inbound
Status: RESOLVED → REOPENED
Flags: needinfo?(pivanov)
Resolution: FIXED → ---
Hey Carsten,

I'm not sure whats wrong here ... because the only one thing that I saw is the lint error and I think that this error is because of !important rules that we use here ... but we don't have other option to override web components styles ... can you suggest something we can do to resolve this errors?
Flags: needinfo?(pivanov) → needinfo?(cbook)
(In reply to Pavel Ivanov [:ivanovpavel][:pivanov] from comment #6)
> Hey Carsten,
> 
> I'm not sure whats wrong here ... because the only one thing that I saw is
> the lint error and I think that this error is because of !important rules
> that we use here ... but we don't have other option to override web
> components styles ... can you suggest something we can do to resolve this
> errors?

You need to adjust the warning/error count in build/csslint/xfail.list
Flags: needinfo?(cbook)
Attached file patch for Gaia/master — 
Waiting to see green light :)
Landed to master:

https://github.com/mozilla-b2g/gaia/commit/17d782b0583011f9b0967c517195e1c89e1e4511
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: