Closed
Bug 1091888
Opened 10 years ago
Closed 10 years ago
openToolbox() should accept non-function objects
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Unassigned)
References
Details
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•10 years ago
|
||
Attachment #8514594 -
Flags: review?(rFobic)
|
||
Updated•10 years ago
|
Priority: -- → P2
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8514594 [details] [review] Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1688 Changes are fine but pull needs to be updated so it does not include unrelated changes.
Attachment #8514594 -
Flags: review?(rFobic) → review+
|
||
Comment 3•10 years ago
|
||
> Changes are fine but pull needs to be updated so it does not include unrelated changes.
What is exactly unwanted in the patch? The change for |openToolboxPanel|?
Florent|
|
Reporter | |
Updated•10 years ago
|
Flags: needinfo?(rFobic)
|
|
||
Comment 4•10 years ago
|
||
After last merge everything seems to look fine now.
Flags: needinfo?(rFobic)
|
||
Comment 5•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/ed01fee5897f279f2d5e566a11372d7abb824aa6 Merge pull request #1688 from fflorent/master Bug 1091888 openToolbox() should accept non-function objects r=@gozala
|
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•