Update Remote debugging UI

RESOLVED FIXED in Firefox 36

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: liuche, Assigned: liuche)

Tracking

Trunk
Firefox 36
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Namely, the following:
- Remove the toast about port forwarding because it's no longer necessary with bug 982890.
- Change "Learn more" link to go directly to the Firefox for Android-specific remote debugging docs, which was given its own page recently.
https://developer.mozilla.org/en-US/docs/Tools/Remote_Debugging/Firefox_for_Android
(Assignee)

Comment 1

4 years ago
Created attachment 8514614 [details] [diff] [review]
Patch: Fix link, remove toast
Assignee: nobody → liuche
Status: NEW → ASSIGNED
Attachment #8514614 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

4 years ago
Depends on: 982890
Developers don't need port forwarding if they're using the WebIDE, but I think they might still need it to use the Connect... menu item directly. We should probably update the MDN article to point people to use WebIDE for Fx36+ if that's going to be our most supported way to debug Fennec.

jryans, is there a plan to update the Fennec remote debugging MDN page?
Flags: needinfo?(jryans)
(In reply to :Margaret Leibovic from comment #2)
> Developers don't need port forwarding if they're using the WebIDE, but I
> think they might still need it to use the Connect... menu item directly. We
> should probably update the MDN article to point people to use WebIDE for
> Fx36+ if that's going to be our most supported way to debug Fennec.
> 
> jryans, is there a plan to update the Fennec remote debugging MDN page?

Oh, I see bug 1091894 was filed. Nevermind :)
Flags: needinfo?(jryans)
Comment on attachment 8514614 [details] [diff] [review]
Patch: Fix link, remove toast

Review of attachment 8514614 [details] [diff] [review]:
-----------------------------------------------------------------

Provided the documentation is updated, this looks good to me.
Attachment #8514614 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 5

4 years ago
Updating the dependency to block on docs-update.
Depends on: 1091894
No longer depends on: 982890
(Assignee)

Comment 6

4 years ago
https://hg.mozilla.org/integration/fx-team/rev/31a7da65598b
Target Milestone: --- → Firefox 36
https://hg.mozilla.org/mozilla-central/rev/31a7da65598b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.