1091910 - [System]Pressing the "battery is low" notification will sometimes cause the rocket bar and keyboard to pop up, and will fail to bring up the battery section in the settings menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[cnelson]

When the users device is very low on battery life, a notification will appear at the top of the screen of the device.  When the user presses the notification, the rocket bar and keyboard will sometimes pop up.  Note that pressing the notification will also fail to bring the user to the battery section of the settings menu.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141029001202
2) Acquire a device that has a battery with very low life left.
3) Plug the device into a laptop.
4) Disconnect the plug from the device.
5) Press the battery is low notification that appears near the top of the screen.
6) Notice the rocket bar and keyboard will pop up, and the user will not be taken to the battery section of the settings menu.
  
Actual:
Keyboard and rocket bar will pop up when pressing the "battery is low" notification, and will fail to take the user to the battery section of the settings menu.
  
Expected: 
Pressing the "battery is low" notification will bring the user to the battery section of the settings menu.
  
Environmental Variables:
Device: Flame 2.1
BuildID: 20141029001202
Gaia: eb0aab0f13c78c7ac378ad860e865c4b6eaf669f
Gecko: 318019f80a8e
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Notes: Unable to recover a logcat as the user must disconnect the battery from the computer to reproduce the issue.
  
Repro frequency: 100%
See attached: video clip https://www.youtube.com/watch?v=9imLDIzaXC0

Comment 1

[cnelson]

This issue occurs on Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash), and Flame 2.0 (319mb)(Kitkat Base)(Full Flash).

Keyboard and rocket bar will pop up when pressing the "battery is low" notification, and will fail to take the user to the battery section of the settings menu.

Flame 2.2

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029040208
Gaia: 35e87ac4324f0f3abd93dcc70d61c9f37256a0f5
Gecko: 7e3c85754d32
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.0

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029000205
Gaia: 9f5b6f025e528fabfcc068782cb9b492cb51a7f9
Gecko: de8cfd54bf93
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is inconsistent behavior compared with other notifications so nominating this 2.0?. I would expect to be taken to the battery settings menu when tapping on a low battery notification.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Hi etienne, I've implemented the feature requested.

Thanks!

Comment 4

[Etienne Segonzac (:etienne)]

Comment on attachment 8515903 [details] [review]
Proposed patch

nice!
optional comment: going through `handleEvent` instead of inlining the click handler will make it easier in the future to implement a `stop` method removing all the listeners.

Comment 5

[Wayne Chang [:wchang]]

Mike,

Can someone suggest if this is a change in UX we want to take? I think it has been this way consistently since 1.1.

Noming this to 2.2 since we've passed FC for 2.1 also.

Comment 6

[GoodMike]

Hi Francis, Can you help to check out the issue ?

Comment 7

[Francis Djabri [:djabber]]

I totally agree that bringing up the keyboard and expanding the rocket bar makes absolutely no sense. Directing the user to the Battery settings so that they can activate power save mode sounds like a reasonable action to me on tap. I'm not sure if we're planning any changes to this for 2.2. - I know that saving battery is a theme but I'm not aware of any specific UI changes involving this. 

Jenny, are you aware of anything we should take into consideration around Battery settings?

Comment 8

[Jenny Lee]

Attachment: battery almost empty.png

Hi cnelson,

Based on your description, I think the "notification" you see is the one as attached, please confirm. This "notification" will only appear when user unplug device from power source at low battery state.

If so, note that the "notification" is actually a hard-coded banner-like overlay, similar to the volume level overlay you see from adjusting volume using hardware key. The overlay is not tappable, it's simply a temporary reminder of battery state and will dismiss itself after a brief moment. 

Since rocket bar is later introduced to Firefox OS, the root cause for the issue you described is probably because we didn't handle the case when there's something (ex. battery low overlay, volume overlay) covering rocket bar, it shouldn't be tappable. So, there should be no problem if we fix this. Thanks!

Comment 9

[Manuel Casas Barrado [:mancas]]

According to Jenny's comment this patch has no sense. I'm going to develop a new one to prevent tap event propagation, in the system overlay.

However, this notification will be showed to the user every time he unlock the screen or unplug device from power source as Jenny said. I believe it could be a good idea to allow user tap the notification to enable power save feature, but it's my opinion.

Comment 10

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

This patch allow the user taps on the system overlay, without launching the rocketbar

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 8518828 [details] [review]
Proposed patch

lgtm :)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/7d50a4aab49719bdaa87f3dcc1e25f002c5569fa

Comment 13

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame 2.2.

Result: Nothing happens when tapping the system overlay.

Device: Flame 2.2 Master (319mb, KK, Shallow Flash)
BuildID: 20141117040203
Gaia: ddf5b92f43ec27c93ad4fea4fd1207da8936b8e7
Gecko: 21b745197618
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
=================================================

Leaving verifyme for 2.1 patch uplift.

Comment 14

[Kevin Grandon :kgrandon]

Backed out for a few reasons:

1 - The commit message did not have a valid bug number, makes it more difficult to track down when it causes regressions (as this did).
2 - Causing bug 1106265, "Can't unlock phone while volume overlay is displayed".

Backout: https://github.com/mozilla-b2g/gaia/commit/82926b52885b1a29da893764c2cc03f938a3b0cd

Comment 15

[Manuel Casas Barrado [:mancas]]

Forget my comment in bug 1106265. I thought it was another bug. I will take into account your issue.

Thanks for backing out my patch

Comment 16

[Manuel Casas Barrado [:mancas]]

Attachment: Proposed patch

Etienne, could you review this new approach when you get a chance?

Thanks!

Comment 17

[Etienne Segonzac (:etienne)]

Comment on attachment 8531522 [details] [review]
Proposed patch

r=me with the changes moved to their respective CSS files (like battery_overlay.css) so that we can see that the element with |pointer-events:auto| doesn't have a height of 100%.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/1c89a60723ae27e6eb6d3f7aeeca5efbf4c9beb5

Comment 19

[sarsenyev]

Verified the issue is fixed on 2.2 Flame

As per comment 8, the hard-coded "Low-Battery" pops up and doesn't retrieve the keyboard when tapping on it.
As per comment 8, the hard-coded message shouldn't navigate to the user to the "Settings"

Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141209040203
Gaia: 9e0b96c7b61c7ff943876ca93e2596d972437b80
Gecko: acf5660d2048
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
==================================================================
Leaving "verifyme" for 2.1 patch uplift