Closed Bug 1091936 Opened 7 years ago Closed 7 years ago

Use proper English for dataroaming and wi-fi sharing/usb tethering strings

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S8 (7Nov)

People

(Reporter: aryx, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
aryx
: review+
flod
: review+
Details | Review
The following strings on 2.2 don't use standard English and are partially confusing:

From bug 1026306:
Current string: noSIMCardInHotspot2=SIM card is absent or inserted incorrectly, so turn off hotspot.
The device is automatically turning off the hotspot. At the moment it sounds like an instruction to the user.
Suggestion: noSIMCardInHotspot3=SIM card is absent or inserted incorrectly, so turning off hotspot.

From bug 796428:
Current string: data-roaming-enabled-warning=In order to access network via data connection, you also need to turn on data roaming. Depending on your service agreement, extra charges may apply. Do you want to proceed?
Does "network" mean "Internet" or "mobile network" here?
Suggestion: Either "In order to access the Internet via data connection, [...]" or "In order to access the data connection of the network, [...]"
Ni? on FxOS... Can we have some feedback on the strings listed in the description?
Flags: needinfo?(firefoxos-ux-bugzilla)
Oh goodness. :)

For the string for bug #1026306, I suggest "Turning off hotspot: SIM card absent or inserted incorrectly."

For the string for bug #796428, I prefer the "In order to access the Internet, you need to turn on data roaming. Depending on your service agreement, extra charges may apply. Do you want to turn data on?"

Flagging Matej for a sanity check.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(Mnovak)
Summary: Use standard English for dataroaming and wi-fi sharing/usb tethering strings → Use proper English for dataroaming and wi-fi sharing/usb tethering strings
(In reply to Stephany Wilkes from comment #2)
> Oh goodness. :)
> 
> For the string for bug #1026306, I suggest "Turning off hotspot: SIM card
> absent or inserted incorrectly."

Is it accurate that it's turning off, or will it already be switched off at this point? I would also suggest "missing" instead of "absent."

"Hotspot off: SIM card missing or inserted incorrectly."

"off" could also be "disabled"

> For the string for bug #796428, I prefer the "In order to access the
> Internet, you need to turn on data roaming. Depending on your service
> agreement, extra charges may apply. Do you want to turn data on?"

This one looks great.

Thanks.
Flags: needinfo?(Mnovak)
Agree with everything Matej wrote. Thanks!
I'll go ahead and give these strings a quick update.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
Attached file Github pull request
aryx or flod - would either of you guys be willing to put a review stamp on this to make sure you are happy with the strings? Thanks!
Attachment #8515364 - Flags: review?(francesco.lodolo)
Attachment #8515364 - Flags: review?(archaeopteryx)
Comment on attachment 8515364 [details] [review]
Github pull request

String-wise it looks good to me.
Attachment #8515364 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8515364 [details] [review]
Github pull request

r+ for strings
Attachment #8515364 - Flags: review?(archaeopteryx) → review+
In master: https://github.com/mozilla-b2g/gaia/commit/c2c55870de22d596de4f41612c0b44090f90ebad
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.