Closed Bug 1091953 Opened 9 years ago Closed 9 years ago

[e10s] Fix about: protocol shim for Adblock

Categories

(Firefox :: Extension Compatibility, defect)

Product:
Firefox
Component:
Extension Compatibility
Version:
34 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 36

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file)

fix-adblock-bug
1.16 KB, patch
mconley
: review+
Details | Diff | Splinter Review
Attached patch fix-adblock-bug — — Splinter Review 
Bug 1067468 added a new parameter to nsIAboutModule.newChannel. Adblock doesn't actually use this parameter, but we need to pass something for it or else xpconnect is unhappy.

I contemplated writing a test for this, but it would be pretty tricky and it doesn't seem worth it.
Attachment #8514703 - Flags: review?(mconley)
Comment on attachment 8514703 [details] [diff] [review]
fix-adblock-bug

Review of attachment 8514703 [details] [diff] [review]:
-----------------------------------------------------------------

From what I can tell, this load info argument is never actually used - but I can believe that XPCOM complains when you don't hand it the right number of arguments.
Attachment #8514703 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/4bfb7fa376a7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.