Closed Bug 1091964 Opened 5 years ago Closed 5 years ago

[e10s] Don't send messages for isCallable and isConstructor CPOW hooks

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36
Tracking Status
e10s m4+ ---

People

(Reporter: billm, Assigned: billm)

References

Details

Attachments

(1 file)

Attached patch fix-iscallableSplinter Review
Right now, whenever the JS engine does isCallable or isConstructor on a CPOW, we send a message to the other side asking for the answer. However, these results are currently constant for a given object, so it makes sense to send this information when the CPOW is created.

At first I came up with a complex scheme for sending data about "new" objects that the other side hadn't seen before. However, I think it makes more sense just to send this data every time we reference a given object. Sending a few extra bytes is cheap, especially compared to what we're saving here, which is an entire sync roundtrip.

This reduces the number of CPOW IPC calls in a testcase I have from 19105 to 16837.
Attachment #8514713 - Flags: review?(mrbkap)
Attachment #8514713 - Flags: review?(mrbkap) → review+
The rooting hazards that this patch was implicated in did not go away after the backout. Relanding.
https://hg.mozilla.org/integration/mozilla-inbound/rev/054f17d341c1
Apparently it was actually my fault, although the hazard is a false positive. Fixed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/37c92f53bfd2
https://hg.mozilla.org/mozilla-central/rev/054f17d341c1
https://hg.mozilla.org/mozilla-central/rev/37c92f53bfd2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.