1091975 - Android NDK r10c failure building breakpad: error: 'ElfELFSIZE_Addr' does not name a type

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Douglas Crosher [:dougc]]

Looks like ELFSIZE is not defined for android-21. A workaround is to use ARCH_ELFSIZE in toolkit/crashreporter/google-breakpad/src/common/android/include/link.h

There are still references to ELFSIZE in NDK r10c android-21 header files, so this might be a regression in NDK.

Comment 1

[Mike Hommey [:glandium]]

There are DEFINES for ELFSIZE in various moz.build files. Is one missing?

Comment 2

[Mike Hommey [:glandium]]

ah, it's for gonk only.

Comment 3

[Douglas Crosher [:dougc]]

Same issue building: tools/profiler/LulElfInt.h

Comment 4

[Mike Hommey [:glandium]]

We shouldn't be using ELFSIZE at all. It's not defined in glibc, and hardcoding 32 for gonk is wrong anyways, it should be related to sizeof(void*)

Comment 5

[Douglas Crosher [:dougc]]

Attachment: For the benefit of Android NDK r10c replace uses of ELFSIZE with ARCH_ELFSIZE

Note what you asked for, but this quick patch works for NDK r8d+. Try build: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1afc289b6c3b

Comment 6

[Makoto Kato [:m_kato]]

This will be fixed by r1300 on BreakPad upstream.


r1300 | [e-mail] | 2014-04-03 08:02:31 +0900 (Thu, 03 Apr 2014) | 8 lines

Remove some unecessary Android system header definitions.

Newer NDKs include some additional headers needed by Breakpad, so we can remove these redefinitions.

BUG=358831,335641,354405
R=[e-mail]

Review URL: https://breakpad.appspot.com/1374002

Comment 7

[(not currently active) Ted Mielczarek]

You're welcome to try to cherry-pick the upstream revision. I'm not sure if it breaks building with NDKs older than r10c though, which would make integrating it directly a little tricky.

Comment 8

[Gabriele Svelto [:gsvelto] (PTO)]

This has been fixed a while ago.