Android NDK r10c failure building breakpad: error: 'ElfELFSIZE_Addr' does not name a type




4 years ago
4 years ago


(Reporter: dougc, Unassigned)


Firefox Tracking Flags

(Not tracked)


(Whiteboard: [ndk-r10c])


(1 attachment)



4 years ago
Looks like ELFSIZE is not defined for android-21. A workaround is to use ARCH_ELFSIZE in toolkit/crashreporter/google-breakpad/src/common/android/include/link.h

There are still references to ELFSIZE in NDK r10c android-21 header files, so this might be a regression in NDK.
There are DEFINES for ELFSIZE in various files. Is one missing?
ah, it's for gonk only.

Comment 3

4 years ago
Same issue building: tools/profiler/LulElfInt.h
We shouldn't be using ELFSIZE at all. It's not defined in glibc, and hardcoding 32 for gonk is wrong anyways, it should be related to sizeof(void*)

Comment 5

4 years ago
Created attachment 8515584 [details] [diff] [review]
For the benefit of Android NDK r10c replace uses of ELFSIZE with ARCH_ELFSIZE

Note what you asked for, but this quick patch works for NDK r8d+. Try build:
This will be fixed by r1300 on BreakPad upstream.

r1300 | | 2014-04-03 08:02:31 +0900 (Thu, 03 Apr 2014) | 8 lines

Remove some unecessary Android system header definitions.

Newer NDKs include some additional headers needed by Breakpad, so we can remove these redefinitions.


Review URL:
You're welcome to try to cherry-pick the upstream revision. I'm not sure if it breaks building with NDKs older than r10c though, which would make integrating it directly a little tricky.
You need to log in before you can comment on or make changes to this bug.