109205 - override the commandset for globalEditMenuItems and goUpdateSelectEditMenuItems

Status: NEW

(MailNews Core :: Composition, defect)

Description

[Scott MacGregor]

Currently every focus and select events triggers command updating for the
following two command sets:

goUpdateSelectEditMenuItems
globalEditMenuItems

this is because those commandsets are defined in utilityOverlay.xul and we (in
mailnews) don't have any control over them. 

We recently made some huge performance wins in mailnews compose and in the
3-pane by creating custom events which we fire only when we want certain
commands to be updated. These 2 command sets were the only 2 which couldn't be
converted because they were defined outside of our control. 

I just discovered in Bug #108761, that it's possible to "override" those command
sets with our own custom events by redefining the command set in an overly that
gets brought in AFTER utilityOverlay.xul. 

We need to make the same change I made in 108761 to the compose window. this
will remove the last of the unncessary command updating you still see. 
In particular:
cmd_undo, cmd_redo, cmd_delete

Comment 1

[Scott MacGregor]

keywords.

Comment 2

[Jean-Francois Ducarroz]

-->varada

Comment 3

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 4

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 5

[Serge Gautherie (:sgautherie)]

Filter on "Nobody_NScomTLD_20080620"

Comment 6

[Wayne Mery (:wsmwk)]

if bug 108761 comment 9 is representative of what we can expect, this is only a 1% gain

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to Scott MacGregor from comment #0)
> Currently every focus and select events triggers command updating for the
> following two command sets:
> 
> goUpdateSelectEditMenuItems
> globalEditMenuItems
> ...
> We need to make the same change I made in bug 108761 to the compose window. this
> will remove the last of the unncessary command updating you still see. 
> In particular:
> cmd_undo, cmd_redo, cmd_delete

Aceman, is this still valid - that the work hasn't been done yet, and that the idea is not obsolete/actually needed?

Comment 8

[:aceman]

The mentioned functions still exist.
But I'm not familiar with what the problem actually is here.

Comment 9

[Wayne Mery (:wsmwk)]

AIUI, the desired performance result is bug 108761 comment 9, achieved in compose by overriding command sets goUpdateSelectEditMenuItems and globalEditMenuItems with custom events per attachment 57163 [details] [diff] [review], and thereby avoid unnecessary command updating on every focus and select events (assuming the later is still true)

They seemed quite please with the results in bug 108761, although it is not clear from the bug "how much" was gained.