Firefox: 1. There were incomplete fields, I click "donate". 2. I go back and complete all the fields. 3. Error doesn't disappear once all required fields are completed: http://note.io/1wjqrl7
Happens on Android too: http://note.io/1wjvORc
Interesting, I'll see what I can do. It's a conflict between selected/error states. Selected adds a blue border, error adds a red, selected overrides error states. I can reverse it, but I don't think that's really complete. I'm thinking what would be ideal is the most recent state is the one that is displayed. Clicking or focusing on an input maybe should clear the error state.
Opps, that was meant for bug #1092057
Created attachment 8515146 [details] [review] https://github.com/mozilla/bsd-forms-and-wrappers/pull/14 The privacy error is independent and seems to work fine as is. It's the form field error that doesn't go away until you submit and get them all right. I guess we can just clear the one line error for form fields as soon as one item is updated. I wasn't too keen on tracking all errors, and removing the dialog once all the errors were updated, while possible, doesn't seem worth it? Thoughts?
This is merged & deployed, closing.