If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Error doesn't disappear, even tho all fields are complete

RESOLVED FIXED

Status

Mozilla Foundation Communications
Website
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: andreawood, Assigned: thecount)

Tracking

Details

(Whiteboard: [EOYFR2014][donation flow][oct31])

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Firefox:

1. There were incomplete fields, I click "donate".

2. I go back and complete all the fields.

3. Error doesn't disappear once all required fields are completed:
http://note.io/1wjqrl7
(Reporter)

Comment 1

3 years ago
Happens on Android too:
http://note.io/1wjvORc
(Assignee)

Updated

3 years ago
Assignee: aki → scott
(Assignee)

Comment 2

3 years ago
Interesting, I'll see what I can do.

It's a conflict between selected/error states. Selected adds a blue border, error adds a red, selected overrides error states. I can reverse it, but I don't think that's really complete.

I'm thinking what would be ideal is the most recent state is the one that is displayed. Clicking or focusing on an input maybe should clear the error state.
(Assignee)

Comment 3

3 years ago
Opps, that was meant for bug #1092057
This is specifically because privacy policy is required. Scott, do you have any ideas on this? It was raised in my friend-QA too.
(Assignee)

Comment 5

3 years ago
Created attachment 8515146 [details] [review]
https://github.com/mozilla/bsd-forms-and-wrappers/pull/14

The privacy error is independent and seems to work fine as is.

It's the form field error that doesn't go away until you submit and get them all right.

I guess we can just clear the one line error for form fields as soon as one item is updated. I wasn't too keen on tracking all errors, and removing the dialog once all the errors were updated, while possible, doesn't seem worth it?

Thoughts?
Attachment #8515146 - Flags: review?(aki)
(Reporter)

Comment 6

3 years ago
Could we just turn the checkbox itself RED if unchecked, and get rid of the separate "you must agree to the privacy policy" error alltogether?
Attachment #8515146 - Flags: review?(aki) → review+
This is merged & deployed, closing.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.