1092073 - [FFOS2.0][Settings][Language]The font changed to unbold after set language as Greek.

Status: VERIFIED FIXED

Description

[sync-1]

Created an attachment (id=992088)
 pic
 
 DEFECT DESCRIPTION:
 ->The font will change after set language as Greek.
 
 REPRODUCING PROCEDURES:
 ->Settings ->Language ->Change language as Greek---KO
 中文描述：
 将语言设为希腊语时，其他语言字体由加粗状态变成不加粗；
 将语言设为中文（其他非希腊语）时，其他语言字体变回原来的加粗状态。
 
 EXPECTED BEHAVIOR:
 ->The font won't change.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 100%
 0752-2639344/61344
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Created attachment 8514883 [details]
pic

Comment 2

[Josh Cheng [:josh]]

Hi Evelyn, Hi Gary,
Though this is polish issue. Could you check whether we unbold the font after change language to Greek?
Thanks!

Comment 3

[Evelyn Hung]

Maybe the applied font files are different because of language setting. It seems not a blocker, so put it in low priority queue.

Comment 4

[Josh Cheng [:josh]]

Hi Chens,
Do you have any finding? Thanks!

Comment 5

[Sherman Chen [:chens] (inactive)]

CSS properties for Greek and all the other languages are the same, I think it might be related to fonts but not sure about. Michael, do you have any ideas about this?

Comment 6

[Michael Wu [:mwu]]

This is working as intended - Fira before FFOS 2.1 did not have sufficiently good Greek support. For 2.1 and newer, we can consider switching the default font to Fira - I don't know if the Greek support with the newest Fira is considered sufficient. It's also possible to backport the new Fira with better Greek support to 2.0 if we really want this.

Comment 7

[Josh Cheng [:josh]]

Hi Peipei,
Can you check whether 2.1/2.2 with new Fira font still have this problem? Thanks!

Comment 9

[Michael Wu [:mwu]]

2.1/2.2 still use different fonts for Greek. However, we may be able to switch 2.1/2.2 to Fira for Greek.

Comment 10

[Michael Wu [:mwu]]

Created attachment 8518306 [details] [diff] [review]
Set Fira as the default font for Greek

Can we switch over with the new Fira?

Comment 11

[Jonathan Kew (:jfkthame)]

I suspect the rendering of Roboto (which is used as default when Greek is selected) is excessively thin when it appears as light-on-dark, but would be OK in a dark-on-light context; it's a TrueType font, and depending on the rasterizer and hinting/antialiasing settings, this can sometimes be a problem.

That doesn't help fix things, but just noting that the issue is likely to be much less noticeable in other contexts, depending on styling.

As for switching to use Fira for Greek: I think we should go ahead, but let's see what Patryk thinks.

Comment 12

[Patryk Adamczyk [:patryk] UX]

Comment on attachment 8518306 [details] [diff] [review]
Set Fira as the default font for Greek

Let's make the switch.

Comment 13

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/cdbaa127d3b2

Comment 14

[Michael Wu [:mwu]]

In order to backport this to 2.0m, two other bugs must also be backported to 2.0m - bug 987872 and bug 1032659 . If you want this bug to block 2.0m, please also set those other two bugs to block 2.0m.

Comment 15

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/cdbaa127d3b2

Comment 16

[Peipei Cheng (needinfo if you need my action)]

(In reply to Josh Cheng [:josh] from comment #7)
> Hi Peipei,
> Can you check whether 2.1/2.2 with new Fira font still have this problem?
> Thanks!

I see the same behavior on Flame 2.0/2.1/2.2

Comment 17

[Josh Cheng [:josh]]

(In reply to Peipei Cheng from comment #16)
> (In reply to Josh Cheng [:josh] from comment #7)
> > Hi Peipei,
> > Can you check whether 2.1/2.2 with new Fira font still have this problem?
> > Thanks!
> 
> I see the same behavior on Flame 2.0/2.1/2.2

Hi Peipei,
According to comment 15. the bug should be fixed in 2.2. Can you retest this on 2.2 and also capture picture which we can decide whether to land it back to 2.0M?
Thanks!

Comment 18

[Michael Wu [:mwu]]

Josh, please read comment 14.

Comment 19

[Josh Cheng [:josh]]

(In reply to Michael Wu [:mwu] from comment #14)
> In order to backport this to 2.0m, two other bugs must also be backported to
> 2.0m - bug 987872 and bug 1032659 . If you want this bug to block 2.0m,
> please also set those other two bugs to block 2.0m.

Triage:
Hi Michael, I have marked bug 987872 and bug 1032659 to 2.0M+. Thanks for the help!

Comment 20

[Peipei Cheng (needinfo if you need my action)]

Josh, comment 16 is to answer your question in comment 7. And I tested on an earlier build 20141103040202, so I can still this issue on that build.

I tested on today's build and the font will not change bold after i change language to greek.

Gaia-Rev        5ae28ff11b982e2bd7d1aa097cda131536952bdc
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/a926116946f8
Build-ID        20141111160205
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141111.192537
FW-Date         Tue Nov 11 19:25:48 EST 2014
Bootloader      L1TC00011880

Comment 21

[Kai-Zhen Li [:seinlin][:kli]]

Uplift to v2.0m got conflicts.

Comment 22

[Michael Wu [:mwu]]

Created attachment 8522755 [details] [diff] [review]
Set Fira as the default font for Greek (v2.0m)

Comment 23

[Kai-Zhen Li [:seinlin][:kli]]

http://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/3ffe3416a003

Comment 24

[Josh Cheng [:josh]]

Hi Hubert,
As we discussed yesterday. Please build multi-lingual version for verification. Thanks!

Comment 25

[Hubert Lu[:hlu] <[e-mail]>]

(In reply to Josh Cheng [:josh] from comment #24)
> Hi Hubert,
> As we discussed yesterday. Please build multi-lingual version for
> verification. Thanks!

This issue could not be found on woodduck 2.0m.

== Build Information ==
Gaia-Rev        cc690f8016b672475dc186bc7fd58aef45e684b7
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141118184148
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1416306679
FW-Date         Tue Nov 18 18:31:44 CST 2014