Closed
Bug 1092103
Opened 10 years ago
Closed 10 years ago
TEST-UNEXPECTED-FAIL | null | LockScreen notification tests close notification
Categories
(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S8 (7Nov)
People
(Reporter: daleharvey, Assigned: kgrandon)
References
Details
(Keywords: intermittent-failure, Whiteboard: [systemsfe])
Attachments
(1 file)
Reporter | ||
Comment 1•10 years ago
|
||
Alive could you recommend anyone to look into this? will disable the test on tuesday as we are getting close to Gij unhidden, thanks
Flags: needinfo?(alive)
Reporter | ||
Comment 2•10 years ago
|
||
3 failing tests I meant
Comment 4•10 years ago
|
||
A similar issue has been reported, but currently I don't have any clue about that. I plan to handle it after I clean the current on going refactoring bugs. Since to handle bugs like this is may take lots of time, until I can find the root cause. So if closing is helpful for Gij unhidden, please do it.
Flags: needinfo?(gweng)
Assignee | ||
Updated•10 years ago
|
Keywords: intermittent-failure
Assignee | ||
Comment 5•10 years ago
|
||
I think the problem here is that the test is removing an element from the dom, and then it's trying to create this "detail" object from the element which no longer exists in the dom. This is potentially a problem anywhere in the tests where we remove/alter dom nodes, then call toDetail() on them. I believe this would only be a problem where we call .not(), followed by some assertion. E.g., .not().contains() Luckily it appears we only do this twice in the current lockscreen tests, so this should be enough to fix both places. I will run this several times on gaia-try and open it for review once it's confirmed fixed.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8515641 [details] [review] Github pull request Greg - could you give this a review now that try looks good? Thanks!
Attachment #8515641 -
Flags: review?(gweng)
Comment 7•10 years ago
|
||
Comment on attachment 8515641 [details] [review] Github pull request Kevin: it looks good and thanks for helping to solve this issue. However, maybe the patch would be even better if we add some comments about the root cause you mentioned on Bugzilla. Could you comment it and land the patch? Thanks.
Attachment #8515641 -
Flags: review?(gweng) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Added comment and landed: https://github.com/mozilla-b2g/gaia/commit/04e9b2719a24c74ce166dc101a169f9019532f2f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [systemsfe]
Target Milestone: --- → 2.1 S8 (7Nov)
You need to log in
before you can comment on or make changes to this bug.
Description
•