1092142 - [Loop] The call log contact name is not updated if the user remove the phone number in Contact app

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

STR

Precondition: 
- Device A with a contact with valid Loop ID (email) and Logged in Loop. 
- Device B logged with Mobile ID into Loop

1. Device B call Device A. A new entry in the call log of device A is created with the phone number of device B.
2. On device A, long tap the entry just created in the call log
3. Click on Add to existing contact
4. Add the phone number to the contact and click on update button (in Contact app). The call log is updated properly
5. Now, in Contact App open again the contact detail and remove only the telephone number updated in the step 4

ACTUAL RESULT
The call log is not updated with the phone number again. It maintains the name of the contact.

EXPECTED RESULT
The call log should be updated properly. If I remove the phone number, it should show the phone number (loop ID)

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks José

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8515892 [details]
Github pull request

(In reply to mbarone from comment #0)

Cristian, followed the STR and there is something fishy here. Please, read bellow. 

> STR
> 
> Precondition: 
> - Device A with a contact with valid Loop ID (email) and Logged in Loop. 
> - Device B logged with Mobile ID into Loop
> 
> 1. Device B call Device A. A new entry in the call log of device A is
> created with the phone number of device B.
> 2. On device A, long tap the entry just created in the call log
> 3. Click on Add to existing contact
> 4. Add the phone number to the contact and click on update button (in
> Contact app). The call log is updated properly
> 5. Now, in Contact App open again the contact detail and remove only the
> telephone number updated in the step 4

After taking step 5 done, the contact is updated with a bunch of identities (the other phone numbers and emails in the contact). We should see the phone number of party B only, shouldn't we? Moreover as we updated the entry in the call log with the other phone numbers and emails in the contact, the entry shows again the name of the contact (instead of the phone number).

Comment 3

[Cristian Rodriguez (:crdlc)]

I gonna take care of this Friday, thanks

Comment 4

[Cristian Rodriguez (:crdlc)]

I am following the steps provided by Massimo and I cannot find issues with the patch. Once deleted the phone, the call log is updated properly with just the phone number. If I open the contacts app again and I add some phone number or email and go back to Loop, the phone number remains in the call log. If I go again to contacts app and I add the original phone number (the identity) the call log shows the friendly name instead of phone. Again I go to contacts and I delete the phone number and the call log shows the phone number (identity) instead of the friendly name.

Comment 5

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8515892 [details]
Github pull request

Hi guys, adding two reviewers just to land with the first r+ because I don't know who could take a look at here. Thanks a lot

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8515892 [details]
Github pull request

Borja's review here would be fine.

Comment 7

[BMO Automation]

Firefox OS is not being worked on